Skip to content

Refactor: use get_submodule with manual traversal fallback in get_module #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yael-shr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor: use get_submodule with manual traversal fallback in get_module #1677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a9878b
Refactor: use get_submodule with manual traversal fallback in get_module
yael-shr Apr 13, 2026
3cf652c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions auto_round/utils/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,14 +1193,22 @@ def set_attr(model, key, new_attr):


def get_module(module, key):
"""Get module from model by key name using PyTorch native API.

Missing paths return `None` to preserve legacy non-fail-fast behavior.
"""
Get module from model by key name using PyTorch native API with a
fallback to manual traversal for backward compatibility.
"""
try:
return module.get_submodule(key)
Copy link
Copy Markdown
Contributor

@xin3he xin3he Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we had changed it to use get_submodule API.

except (AttributeError, KeyError):
return None
pass

attrs = key.split(".")
for attr in attrs:
try:
module = getattr(module, attr)
except AttributeError:
return None
return module


def set_module(model, key, new_module):
Expand Down