Repository navigation
Truncate logs during formatting - #247
Merged
Merged
Conversation
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change to truncate log messages during formatting.
No open issues 🎉
What changed in this PR
This PR truncates log messages during formatting rather than after building the full string, reducing unnecessary allocations and formatting work.
Changes:
- Adds a length-limited writer that stops formatting when the byte limit is exceeded while preserving UTF-8 boundaries.
- Adds tests for formatting options, early termination, Unicode boundaries, and formatter errors.
- Documents the logging improvement in the changelog.
| File | Description |
|---|---|
src/logging.rs |
Implements truncation during formatting and adds regression tests. |
CHANGELOG.md |
Records the reduction in allocations from large debug messages. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonatan Waern jonatan.waern@intel.com