Skip to content

Take job kind into consideration for their hash - #250

Merged
JonatanWaern merged 1 commit into
mainfrom
fix-race-in-job-cancelling
Nov 4, 2026
Merged

JonatanWaern merged 1 commit into
mainfrom
fix-race-in-job-cancelling

Conversation

@JonatanWaern

Copy link
Copy Markdown
Contributor

Signed-off-by: Jonatan Waern jonatan.waern@intel.com

Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change to distinguish analysis-queue job hashes by job kind.

No open issues 🎉

What changed in this PR

This PR makes analysis-queue job hashes account for job kind, preventing jobs with the same path inputs but different kinds from cancelling one another.

Changes:

  • Adds distinct hash markers for isolated analysis, device analysis, and lint jobs.
  • Documents the fix for repeated analysis cancellation when no import paths can be resolved.
File Description
src/​actions/​analysis_queue.rs Includes a job-kind marker in each job’s hash calculation.
CHANGELOG.md Records the cancellation fix under version 0.9.23.

Review effort: Balanced

@JonatanWaern
JonatanWaern merged commit b1d8cca into main Nov 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants