Skip to content

Copilot's shell command results should carry a real exit code #807

Open

Description

@napetrov

Follow-up from #787 (review thread on choice events).

choices.py gives an install, removal, import or use choice only where the call's exit code is 0. For Copilot, cli_traces.py (_copilot_result) takes rc from shellExecution.exitCode when the result carries one, else from the success flag, and leaves rc as None only when neither is present. A Copilot shell command with neither therefore gives no choice, but one reported only as success: true counts as rc 0 without a recorded exit code.

Proposed: have Copilot's shell results always carry the real exit code, and drop the success-flag fallback for shell commands, so every Copilot choice rests on the code the command returned.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions