Skip to content

feat(repo): fingerprint the host with collectors; --label-host runs a missed host - #781

Open
napetrov wants to merge 21 commits into
intel:mainfrom
napetrov:feat/host-fingerprint-collectors
Open

napetrov wants to merge 21 commits into
intel:mainfrom
napetrov:feat/host-fingerprint-collectors

Conversation

@napetrov

@napetrov napetrov commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A repo task can need a host the grader does not have (a thread race needs 3+ CPUs, an ISA path needs avx512f). Today such a task is marked unsupported on any host that misses it, and results do not record which machine ran them.

This PR:

  • fingerprints the host with a registry of collectors (os, cpu, memory, gpu, python, tools, network, virt) under collectors in the probe facts, with collectors_version 1; a failing collector reports {"error": ...} and the others still run;
  • records nothing identifying: no host or user name, IP address, environment value, interface name or absolute path;
  • adds repo run --label-host: a task the host misses runs anyway, and each cell records host_match (per requirement met, unmet or unknown) in result.json and meta.json; repo report groups rows by host fingerprint and names the host on each row.

Block mode (the default) is unchanged.

Evidence

  • tests/test_host_fingerprint.py: each collector per platform (Linux, macOS sysctl, Windows with fakes), failure isolation, container and VM detection, GPU, and privacy checks run with real and monkeypatched names and addresses.
  • tests/test_repo_host_label.py: AVX-512 task on an AMD host (labelled miss), block-mode regression, Windows host, container, GPU host, report grouping, flag parsing.
  • make ci-local on the head of this push (main merged in): 0 failed, 25 passed, 20 skipped (network-only steps skipped).
  • Local self-review (pr-review, lane L2): no confirmed blocking finding; declined nits and two questions recorded in the review.

Merge Danger

  • Every result.json gains a host_fingerprint key (additive). Batches written before this change group under null.
  • A batch folder holds several hosts' rows only if every host runs the same harness binary and version (the batch_ledger execution id); otherwise the later host is refused.
  • The fingerprint includes OS release, tool versions and the Python version, so a kernel, git or Python upgrade on the same machine splits its result rows. Intended for toolchain-sensitive tasks; please confirm.
  • Each repo run and eval check now spawns up to 10 short version calls (git, docker, cmake, gcc, clang, make, nvidia-smi), each with a 10 s timeout, once per invocation.
  • docs/reference/cli-interface.json is regenerated for the new --label-host flag.
  • Error text is scrubbed of paths: a slash after a space or ( redacts the rest of the line (ratio 3 / 4 done becomes ratio 3 <path>). Intended and fail-safe.
  • Known gaps: matching uses the container's CPU view, not the host collectors; the Windows memory path is exercised only with fakes; the GPU collector is NVIDIA only; label mode is a CLI flag only, no manifest option.

🤖 Generated with Claude Code

… missed host

The host probe now records a fingerprint from a registry of collectors (os,
cpu, memory, gpu, python, tools, network, virt) under `collectors`, beside the
container's unchanged keys. A failing collector reports its error and the
others still run. Nothing identifying (host or user name, address, env value,
interface name, absolute path) is recorded.

`repo run --label-host` runs a task the host misses instead of marking it
unsupported, and records per-requirement `host_match` in result.json and
meta.json. `repo report` groups rows by host fingerprint. Block mode is the
default and unchanged.

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@napetrov
napetrov requested a review from a team as a code owner November 15, 2026 06:12
Copilot AI balanced review requested due to automatic review settings November 15, 2026 06:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

Copy link
Copy Markdown

CLI interface change detected

This PR changes dokimi's user-facing CLI surface (commands and/or options):

~ `dokimi repo run` parameters changed:
    + added option `--label-host`

Updated on every push; the cli-interface-change label is on while the diff is non-empty.

@github-actions github-actions Bot added the cli-interface-change Changes dokimi's user-facing CLI surface label Nov 15, 2026
@exai-bot

exai-bot commented Nov 15, 2026 •

Copy link
Copy Markdown

OpenCodeReview: Commit face922 was not reviewed. This PR has reached its review limit (6 reviews).

CI at `face922`: 12 still running, 5 passing, 1 skipped
Check Status
Build docs (strict) still running
CLI interface diff still running
CodeQL (actions) still running
CodeQL (python) still running
Linux Python 3.11 still running
Linux Python 3.14 still running
Linux Wheels Python 3.11 still running
Linux Wheels Python 3.14 still running
Static checks (ruff, schema, zizmor, licenses, pre-commit, bandit, secrets, changelog, schema com... still running
benchmark still running

2 more not listed.

To review this commit: re-request review from exai-bot in the Reviewers list.

<details><summary>Last review (ed0ec8e): 1 medium</summary>

Open threads from the bot: 0

</details>

Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
Comment thread dokimi/dokimi/repos/report.py Resolved
Comment thread dokimi/dokimi/repos/report.py Resolved
Comment thread dokimi/dokimi/repos/report.py Resolved
Comment thread dokimi/tests/test_host_fingerprint.py Resolved
@codecov-commenter

codecov-commenter commented Nov 15, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 94.33962% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.79%. Comparing base (b62613a) to head (face922).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dokimi/dokimi/repos/host_fingerprint.py 91.06% 14 Missing and 2 partials ⚠️
dokimi/dokimi/repos/report.py 97.33% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #781    +/-   ##
========================================
  Coverage   95.79%   95.79%            
========================================
  Files         432      433     +1     
  Lines       57204    57501   +297     
  Branches     9858     9909    +51     
========================================
+ Hits        54796    55081   +285     
- Misses       1497     1508    +11     
- Partials      911      912     +1     
Files with missing lines Coverage Δ
dokimi/dokimi/commands/repo_run.py 95.81% <100.00%> (+0.01%) ⬆️
dokimi/dokimi/repos/compare.py 99.53% <100.00%> (+<0.01%) ⬆️
dokimi/dokimi/repos/host.py 94.85% <100.00%> (+3.85%) ⬆️
dokimi/dokimi/repos/runner.py 97.22% <100.00%> (+0.09%) ⬆️
dokimi/dokimi/repos/report.py 97.80% <97.33%> (-0.23%) ⬇️
dokimi/dokimi/repos/host_fingerprint.py 91.06% <91.06%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at 2ee29fd. The collector registry is clean and the label mode wiring through run_batch, run_cell and meta.json holds up. The problems are in repo report grouping and in the path redaction the privacy claim rests on. Three bugs and four risks are worth fixing before merge, plus one nit; all are inline.

What I ran, on a Linux review host at 2ee29fd:

  • make ci-local: 33 passed, 0 failed, 14 skipped (the skips are the other-Python legs, semgrep and jobs that do not run on a PR).
  • Reproductions for the report and redaction findings, through summarize, format_report, repo report and scrub, on hand-built batch directories, offline.
  • Mutation runs against tests/test_host_fingerprint.py and tests/test_repo_host_label.py: several mutants of the new code pass the full suite (see the test comments).
  • The commit has a Signed-off-by.

Checked, no issues

  • Label mode: _verdicts returns no unsupported entries in label mode, so old unsupported markers are cleared and --force takes the normal path; a failed probe gives met=None and a note, not a block.
  • Isolation: collect() catches per collector, and spawns get Env.only(PATH, SYSTEMROOT), so no environment value is forwarded.
  • Identity: fingerprint_id ignores the network collector, as the docs say.
  • Docs: the collector names, collectors_version 1 and the 300-character cut in the contract match the code.

Comment thread dokimi/dokimi/repos/report.py Resolved
Comment thread dokimi/dokimi/repos/report.py Resolved
Comment thread dokimi/dokimi/repos/report.py Resolved
Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
Comment thread dokimi/tests/test_host_fingerprint.py Resolved
Comment thread dokimi/tests/test_host_fingerprint.py Resolved
Comment thread dokimi/tests/test_repo_host_label.py Resolved
Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
Comment thread dokimi/dokimi/repos/report.py Resolved

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit per nit, up to 881673e, which fix the nit from my review:

  • 881673e: dokimi/dokimi/repos/host_fingerprint.py:8 and dokimi/docs/repo-evaluation-contract.md:707: both now say the Windows CPU model is platform.processor(), which Windows fills from PROCESSOR_IDENTIFIER.

make ci-local at 881673e: 33 passed, 0 failed, 14 skipped.

Not approving yet. Still open: the three bugs and the four risks from my review.

Fixes in the host fingerprint and its report rows:
- scrub redacts quoted paths with spaces, UNC paths and ~ paths whole.
- The Windows CPU model and vendor come from the registry, not from
  platform.processor(), which reads PROCESSOR_IDENTIFIER.
- repo report refuses a malformed host_fingerprint or host_match with
  exit 2 instead of a traceback.
- A started missing cell counts on its own host's row; an unstarted one
  only when the task, arm and model has a single host row.
- Text rows name their host; an undecided labelled row is not "unmet".
- Tests: IPv4 check skips version strings, every identity collector,
  vendor, min_cpus boundary, flag case and mixed verdicts are pinned.

Signed-off-by: vchamarthi <123653452+vchamarthi@users.noreply.github.com>
@vchamarthi

Copy link
Copy Markdown
Contributor

Pushed 1 commit to feat/host-fingerprint-collectors (881673e..a22fd3a): Ready for re-review; the PR description needs a correction below.

Changes

  • The changelog no longer says nothing changes without the flag, since default repo report splits rows by host fingerprint.
  • A labelled row whose host check could not tell is noted undecided, not unmet: undecided.
  • scrub redacts whole quoted, UNC and ~/ paths.
  • The Windows CPU model comes from the registry, not PROCESSOR_IDENTIFIER.
  • repo report refuses a malformed host_fingerprint or host_match.
  • Missing cells are attributed to the host that started them.
  • Text report rows show host <fingerprint> without label mode.
  • A missing cell whose meta.json host is malformed is placed on no host row instead of crashing the report.

Needs @napetrov

  • PR description says "repo report groups rows by host fingerprint."; it should read: repo report groups rows by host fingerprint and names the host on each row.

Threads and comments

  • Fixed: 13, each answered in its thread.
  • Fixed (comment by @antonwolfy): Not approving; three bugs and four risks still open – Each is answered on its thread.
  • Fixed (comment by @antonwolfy): Windows CPU model docs after 881673e – The docs now say the registry is the source, since the code no longer reads platform.processor().
  • Fixed (comment by exai-bot): host_match field names unvalidated – _check_cell refuses a non-string field name with exit 2, pinned by host-match-field-a-number in tests/test_repo_report_unreadable_cell.py.

Not this PR's

  • Fails on main too: tests/test_repo_compare_interval.py – three interval cases fail on main (test_an_end_is_bounded_at_deltas_too_large_to_move_by_one, test_the_row_p_places_zero_where_large_deltas_round_p_at_zero_apart).
Verified (9)
  • scrub redacts quoted, UNC and ~ paths: passes.
  • a collector error with a spaced path is stored without it: passes.
  • Windows CPU model never reads PROCESSOR_IDENTIFIER: passes.
  • malformed host_fingerprint and host_match are refused with exit 2: passes.
  • missing cells are attributed to their host: passes.
  • IPv4 check ignores a four-part kernel release: passes.
  • identity id changes with every identity collector: passes.
  • a malformed host in a missing cell's meta.json does not crash the report: passes.
  • Full suite with main merged in: 21824 passed.

Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
Comment thread dokimi/dokimi/repos/report.py Resolved
- scrub: close a quoted path on its own quote, run a bare Windows or UNC
  path to the end of the line, keep image names such as ghcr.io/a/b
- report: a started cell whose meta.json host has no collectors counts
  on the unfingerprinted row, as its result.json does

Signed-off-by: vchamarthi <123653452+vchamarthi@users.noreply.github.com>
@vchamarthi

Copy link
Copy Markdown
Contributor

🟢 Ready for re-review · 1 commit on feat/host-fingerprint-collectors (a22fd3a..f042010)

Next: @antonwolfy: re-review the new head. Nothing needed from @napetrov.

Changes

  • scrub redacts a quoted path up to its own closing quote and a bare Windows or UNC path to the end of the line.
  • _started_host returns no fingerprint for host facts without collectors, so a missing legacy cell counts on the None row.
  • Image names are kept by scrub (commit f042010, pinned by a test now).

Threads and comments

  • 2 fixed; each answered in its thread.
  • Already fixed: dokimi/dokimi/repos/host_fingerprint.py:104 (@antonwolfy) – Already fixed on a22fd3a: tests/test_host_fingerprint.py::test_scrub_redacts_quoted_unc_and_home_relative_paths_whole covers the space, UNC and ~ inputs and passes on the head.

Verified on the new head: ✅ tests of the fix: 2 passed · ✅ full suite with main merged in: 21831 passed, 3 failures that main has too · ✅ second reader: 1 raised, all fixed

What each test shows
  • scrub keeps whole paths out and image names in: passes.
  • legacy host facts count on the unfingerprinted row: passes.

Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
scrub() left "cannot open path:/home/jdoe/private" unchanged: the
colon before the slash excluded the path from redaction, and no
test pinned that exclusion. Drop the colon from the lookbehind;
URLs, proxy addresses and image references still come back as written.

Thread: PRRT_kwDOVBg7g863vUNS
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
…ress

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>

@vchamarthi vchamarthi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not approved yet · reviewed f042010

Next: @napetrov: answer 1 open thread from exai-bot (below).

Blocking

  • Still holds on this head: thread by exai-bot – scrub("cannot open path:/home/jdoe/private") still returns the input unchanged on the head.

Verified on f042010: ✅ changed tests: 238 passed, fail on main · ✅ full suite with main merged in: 21846 passed, its only failures are main's too · ✅ merges onto main · 1 mutation tried · 3 edge inputs tried

5 checks behind it, each with its evidence
Area What holds How
Changed tests The five changed test files pass on the head (238 passed, 2 skipped) and fail to import on main tests on the head
Local suite The whole local run passes with main merged in full suite, main merged in
Merge The head merges onto main with no conflict merge onto main
Malformed host keys _check_cell refuses host_fingerprint as {} or 5 and a host_match field named 42 with a CellFileError ran it, edge input (structured)
Flag case Changing flag.lower() in have to flag in have in _match_fields fails tests/test_repo_host_label.py broke the code, tests caught it, edge input (text)

Each item was fixed by an earlier commit of this PR and checked on head.

Thread: PRRT_kwDOVBg7g863m2nt: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863m2nu: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863m2nw: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863m2nz: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863m2n2: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863m2n5: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863pBQc: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863pBQf: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863pBQi: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863pBQk: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863pBQm: already fixed in 881673e
Thread: PRRT_kwDOVBg7g863pBQr: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863pBQt: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863pBQw: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863pIBx: already fixed in a22fd3a
Thread: PRRT_kwDOVBg7g863sCH1: already fixed in f042010
Thread: PRRT_kwDOVBg7g863sCH4: already fixed in f042010
Review: PRR_kwDOVBg7g88AAAABYEpmmA: already fixed in f042010
Review: PRR_kwDOVBg7g88AAAABYEwXWw: already fixed in f042010
Comment: IC_kwDOVBg7g88AAAABmy6k2g: PR description corrected in this round (body edit, no commit)
Comment: IC_kwDOVBg7g88AAAABm3tl6w: already fixed in f042010
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@napetrov

Copy link
Copy Markdown
Contributor Author

Re: review by antonwolfy

Three bugs and four risks are worth fixing before merge
All seven are answered in their threads and fixed on head: a22fd3a and f042010 hold the code, and each thread names its commit.

@napetrov

Copy link
Copy Markdown
Contributor Author

Re: review by antonwolfy

Not approving yet. Still open: the three bugs and the four risks
Each is answered in its thread with a commit on head (a22fd3a, f042010). The new colon-path case is 6d3945e.

@napetrov

Copy link
Copy Markdown
Contributor Author

Re: comment by vchamarthi

the PR description says repo report groups rows by host fingerprint
Corrected: it now also says the report names the host on each row.

@napetrov

Copy link
Copy Markdown
Contributor Author

Re: comment by vchamarthi

Ready for re-review
Thanks. This round pushes the new head; the threads above map each fix to its commit.

Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved

@vchamarthi vchamarthi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not approved yet · re-reviewed b4fdefe

Next: @napetrov: answer 1 open thread from exai-bot (below). 1 nit optional.

Blocking

  • Still holds on this head: thread by exai-bot – On the head cannot open /home/Jane Doe/private gives cannot open <path> Doe/private: an unquoted POSIX path stops at its first space, while /home/张三/private is redacted whole.

Verified on b4fdefe: ✅ changed tests: 239 passed, fail on main · ✅ full suite with main merged in: 22115 passed · ✅ merges onto main · ⚠️ 12 broken variants of the changed code: 9 caught by the tests, 3 not · 1 mutation tried · 2 edge inputs tried

6 checks behind it, each with its evidence
Area What holds How
Colon path redaction cannot open path:/home/jdoe/private gives cannot open path:<path> on the head, the case added in 6d3945e ran it
Scrub on text scrub returns an empty or spaces-only string as given, keeps the image name ghcr.io/intel/dokimi-grader:1, and redacts a bare POSIX path with non-ASCII characters whole ran it, edge input (text)
Colon case pinned Restoring : to the lookbehind of _PATH fails test_scrub_redacts_quoted_unc_and_home_relative_paths_whole, so the colon case is pinned broke the code, tests caught it
Changed tests The five changed test files pass on the head: 239 passed, 2 skipped, including the colon case and the path-redaction cases tests on the head
Local ci The whole local CI run passes with main merged in full suite, main merged in
Merge The head merges onto main with no conflict merge onto main

Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
…ress

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
A bare POSIX path now runs to the end of the line, as a bare Windows or UNC
path already did, so the rest of a path with spaces is not left behind.
The regression cases cover spaces, a Unicode name, a ~ path and a URL.

Thread: PRRT_kwDOVBg7g8630nuX
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Thread: PRRT_kwDOVBg7g864FY2z
Review: PRR_kwDOVBg7g88AAAABYTPWEA
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@napetrov

Copy link
Copy Markdown
Contributor Author

Re: review by vchamarthi

Next: answer 1 open thread from exai-bot
Fixed: f8757b9; the nit: ed0ec8e.

…ress

Resolves report.py: keeps main's batch-field check and mixed-execution
refusal alongside the host-fingerprint row key and host checks.

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
…ress

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
scrub() missed a path behind a file: scheme (file:///home/Jane Doe/x
leaked whole) and a forward-slash UNC path (//server/share/x leaked).
A file: path keeps its scheme, a quoted one keeps its quotes, and a UNC
path is redacted to the end of the line. http and https URLs are
unchanged.

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@napetrov

Copy link
Copy Markdown
Contributor Author

Follow-up for the other URL schemes (smb://, sftp://, ssh://) in the trace scrub: #853.
The path scrub here handles file: and UNC only.

@vlad-perevezentsev vlad-perevezentsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at ac2d4d7. The collectors, the label mode and the fixes from the earlier rounds hold. What is left is in the line comments: a missing cell the per-host rows lose, a fingerprint that a single timeout changes, and repo compare pooling labelled cells with no warning.

What I ran, at ac2d4d7:

  • make ci-local --offline: 23 passed, 0 failed, 20 skipped (network jobs and other Python legs).
  • summarize() on hand-built batches: a crashed cell on a host with no finished cell, and a legacy batch with one new-fingerprint crashed cell. Both rows show missing=0.
  • collect() with a fake runner: a docker --version timeout gives present and a new fingerprint_id, and an OSError for make turns tools into an error.

Checked, no issues

  • Earlier threads: the scrub cases (quoted, UNC, ~, file:, colon, spaces), the registry source for the Windows CPU, the _check_cell refusals and the missing-cell placement all hold on this head.
  • Label mode: _verdicts gives no unsupported entries with the flag, so old markers are cleared, and the block mode is unchanged without it.
  • Changelog and CLI: the fragment describes the flag and the row split, and the CLI snapshot and the flags allowlist match.

Comment thread dokimi/dokimi/repos/report.py Resolved
Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
Comment thread dokimi/dokimi/repos/runner.py Resolved
Comment thread dokimi/dokimi/repos/host_fingerprint.py Resolved
Comment thread dokimi/dokimi/repos/host.py Resolved
Comment thread dokimi/docs/repo-evaluation-contract.md Resolved
A cell that started on a host with no finished cell was in the batch-level
missing list only; the row for its host does not exist, so no row showed it.
It now counts as unplaced, so the single-row rule places it.

Thread: PRRT_kwDOVBg7g864ZGf7
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
A cell run with --label-host on a host that misses its task, or that could
not be checked, was pooled into the delta with no warning. compare now names
those tasks, as it does for a model mismatch.

Thread: PRRT_kwDOVBg7g864ZGgO
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
An OSError from the spawn of a tool that `which` found (a Windows make.cmd
shim) made the whole tools collector an error. The spawn failure is now a
fact about the tool, as a failing --version already is.

Thread: PRRT_kwDOVBg7g864ZGgT
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
The ContainerError text (docker stderr, up to 500 characters) went into
_eval/host.json, meta.json and unsupported.json with paths unchanged. It is
scrubbed like the other probe errors.

Thread: PRRT_kwDOVBg7g864ZGgZ
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Without --label-host a cell still carries host_fingerprint and repo report still
splits rows by it; the contract said nothing changes.

Thread: PRRT_kwDOVBg7g864ZGgd
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
summarize was over the complexity cap (ratchet) with the rowless-host step inline.

Thread: PRRT_kwDOVBg7g864ZGf7
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready to merge. Nothing new from me at ac2d4d7, but the open points from @vlad-perevezentsev still hold at this head, and they are bugs and risks.

I agree with @vlad-perevezentsev's points on the lost missing cell, the id change after one timeout, the tools collector lost to an OSError, the unscrubbed probe error, repo compare and the stale contract line. New evidence: a docker --version timeout changes the id (45f9f04d6b0c to 65ffff68073a).

What I ran, on a Linux review host at ac2d4d7:

  • make ci-local: 34 passed, 0 failed, 14 skipped; changed-line coverage 94%
  • Reproductions of the points above with fake probes, offline.
  • All non-merge commits carry a Signed-off-by.

Checked, no issues

  • Earlier fixes: the report refusals, the placement of started cells, the identity test per collector and the scrub cases from the previous round hold; I have no open thread.

…ress

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@napetrov

Copy link
Copy Markdown
Contributor Author

Re: review by vlad-perevezentsev

What is left is in the line comments
Nothing to change in the summary: each line thread has its own reply, and the open one is held.

…e left out

A collector that still fails after one retry is left out of fingerprint_id, and tools count by
presence, so a timed-out --version does not split one host into two rows.

Thread: PRRT_kwDOVBg7g864ZGgG
Thread: PRR_kwDOVBg7g88AAAABYn7Jtw
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@napetrov

Copy link
Copy Markdown
Contributor Author

Re: review by antonwolfy

Not ready to merge
Fixed in face922: the id; the rest in threads.

@napetrov

Copy link
Copy Markdown
Contributor Author

@vlad-perevezentsev @antonwolfy @vchamarthi all threads fixed and resolved (fingerprint now uses tool presence only; smb/sftp/ssh scrub tracked in #853), CI green on head. Ready for approval.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli-interface-change Changes dokimi's user-facing CLI surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants