Repository navigation
feat(llm): codex-cli and copilot-cli answering providers, one-condition report #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
napetrov
wants to merge
51
commits into
intel:main
Choose a base branch
from
napetrov:feat/knowledge-run-cli-answerers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,998
−170
Open
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
b5fdc8a
feat(eval): document knowledge runs and refuse task-harness labels on…
napetrov 890bcf9
docs(eval): scope the knowledge-run reproduction claim to arms baseline
napetrov a549fff
docs(eval): name agent-CLI harnesses for tasks run and repo run
antonwolfy 7f5b066
docs(eval): say report eval withholds the baseline mean on knowledge …
antonwolfy b361516
feat(llm): codex-cli and copilot-cli answering providers, one-conditi…
napetrov 68e4a73
Merge branch 'main' of https://github.com/intel/dokimi into pr806-kno…
napetrov 2bccf49
Address review: blank Codex reply is a failed call
napetrov a7ac71a
Address review: Copilot tool allow-list, usage limit, Windows cmdline
napetrov f0223e3
Merge branch 'main' of https://github.com/intel/dokimi into pr806-kno…
napetrov 1e37a85
Address review: a run-wide error stops both answering loops
napetrov e022f21
Address review: a one-arm arms run gets its own report
napetrov c2b852f
Address review: the report page names the one-arm run's condition
napetrov a08b943
Address review: say the answer loop stops on a run-wide error too
napetrov 95d0af0
fix(eval): stop the answering loops at a run-wide CLI error
napetrov 2b2e2cd
fix(records): an arms run's failed arm still counts as a condition
napetrov 8030874
docs(knowledge-runs): the one-condition diagnosis is for a binary kno…
napetrov f0cec00
style: keep the moved ground-truth comment to two lines
napetrov 8d28a31
Merge branch 'main' of https://github.com/intel/dokimi into pr806-kno…
napetrov 57f3aa7
fix(knowledge): refuse codex-cli on a knowledge run; stamp the run in…
napetrov 3669d95
Merge branch 'main' of https://github.com/intel/dokimi into pr806-kno…
napetrov e6d5293
fix(copilot): count the terminating NUL in the Windows command-line c…
napetrov 3c10ef4
docs(knowledge): copilot-cli disables its tools with __none__
napetrov d714916
fix(eval): a run-wide failure ends arms run and answers generate nonzero
napetrov 49fc530
fix(report): one-arm report reads an arms artifact's model and answers
napetrov 61233ca
fix(eval): a stopped question has a cell for every arm
napetrov a1c133a
test(eval): the arms run keeps the stopped question's cells
napetrov 8ae6608
refactor(eval): move the run-wide stop and the question record out of…
napetrov 2243cd2
test(copilot): the Windows limit test's comments match the units
napetrov 2f5705f
style(report): drop an unused sys import in the answers reader
napetrov b5bee2d
test(arms): the arms CLI exit and the matrix stop are tested
napetrov 8eda8c0
docs(eval): the run-wide comment says the question keeps its cells
napetrov 4ef49ad
chore(tests): license headers on the two new test files
napetrov 550f6b9
Merge branch 'main' of https://github.com/intel/dokimi into pr806-kno…
napetrov f3636cd
Address review: keep paid-for conditions on a stop, no arm after a stop
napetrov 6dca98b
Address review: bind the copilot prompt to --prompt=
napetrov 6d346cf
Address review: only claude-cli and copilot-cli disable tools
napetrov afdbef8
Address review: judge and report follow the persisted run intent
napetrov fc77bb2
Thread: PRRT_kwDOVBg7g864KTFi: already fixed in 4ef49ad51
napetrov d597fe5
Address review: keep the growth ratchet green
napetrov 4e0838d
Address review: the stopped question's pair is built without reads of…
napetrov fd736bd
Merge branch 'main' of https://github.com/intel/dokimi into pr806-kno…
napetrov 428d9b3
fix(judge): follow the answerer's CLI only for claude-cli
napetrov acbb0a2
fix(cli): require --model for codex-cli and copilot-cli answerers
napetrov ffee845
fix(answers): a run-wide stop is terminated, not judged as complete
napetrov 5a925c2
fix(report): one sibling-answers lookup and the declared-arms branch …
napetrov 4e92488
docs: keep main's no-judge sentence; changelog lists the user-visible…
napetrov ebb4a77
test, docs: name the terminated-block test for what it checks; reflow…
napetrov dea72de
Address review: the open review bodies are answered by the thread fixes
napetrov 5b07c92
fix(ci): split the llm_cli reply tests and extract the arms stop exit
napetrov 88aec76
test: the diagnosis table lists the one-condition label
napetrov 608a5c4
Accept argparse abbreviations of --model in the model check
antonwolfy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 18 additions & 0 deletions
18
dokimi/changelog.d/20261115_120000_knowledge-run-cli-answerers.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <!-- | ||
| Copyright (C) 2026 Intel Corporation | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| --> | ||
|
|
||
| ### Added | ||
|
|
||
| - **`codex-cli` and `copilot-cli` are answering providers** — the OpenAI Codex CLI and the GitHub Copilot CLI, signed in on the machine, answer a question set on a comparison. Each call runs in a fixed empty directory outside any repository, with no user instructions or project docs and no conversation. `claude-cli` and `copilot-cli` run with no tools; `codex-cli` keeps its read-only sandbox, so a Codex comparison can read files, and its scores are not tool-free. Copilot records no token counts and no cost. `--model` is required for both. See [docs/knowledge-runs.md](docs/knowledge-runs.md). | ||
| - **`codex-cli` is refused on a knowledge run** — `answers generate --doc-source none` and `arms run --arms baseline` exit 2 before any call with `--provider codex-cli`: Codex has no switch that turns its tools off, so its answers could read host files. Use `copilot-cli` or `claude-cli`. | ||
| - **A knowledge run is stamped and read as one** — `answers generate` stamps `run_intent` (`knowledge` or `paired`) on the answers file, `eval score` carries it into the eval, and `report eval` writes the one-condition page only for a run stamped as a knowledge run. An unstamped file with no retrieval hit still reads as one; a paired run whose retrieval missed every question gets the paired report. | ||
| - **`terminated` on a run that a usage limit or missing login stopped** — the `answers.v1` and `arms.v1` files record the reason and the questions requested and recorded. | ||
| - **`report eval` on a one-condition (knowledge) run writes a single-condition page** — one row for `without_docs (knowledge)` with its mean, lowest and highest score, by difficulty, the lowest-scoring questions, and every question with its score. Paired runs keep the paired report. | ||
|
|
||
| ### Changed | ||
|
|
||
| - **`claude-cli` stops at a usage limit or missing login** — `answers generate` and `arms run` keep what was answered, save it, and exit 1; `evaluate` and `benchmark run` do not judge or report a stopped answers file as a complete run. | ||
| - **The judge follows a CLI answerer only on `claude-cli`** — `codex-cli` and `copilot-cli` answerers keep the API default judge unless `--judge-provider` names a CLI. | ||
| - **Per-question diagnosis of a knowledge run is `⚪ One condition (no delta)`** — `eval score pointwise` no longer reports `insufficient_data` for a question that has one condition and no context answer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.