Repository navigation
fix(cli): exit codes for repo run crashes, cross-judge verdicts, unread traces (#94 A2b, #275) #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
napetrov
wants to merge
23
commits into
intel:main
Choose a base branch
from
napetrov:fix/cli-a2b5-exits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+513
−72
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c80c2fd
fix(cli): exit codes for repo run crashes, cross-judge verdicts, unre…
napetrov 71ec3ca
Merge branch 'main' of https://github.com/intel/dokimi into r6/pr810
napetrov 500310d
Address review: match only the docker CLI's own daemon diagnostic
napetrov 3cc2398
Address review: pin the infra exit of an unwritable cell result and s…
napetrov 77cb2ee
Address review: accept the older CLI's "Got permission denied" socket…
napetrov d667588
Address review: match the full summary line of the unwritable-result …
napetrov eacee60
Mark the A2b test renames as narrowed on purpose
napetrov a53ee3d
Merge intel/main into fix/cli-a2b5-exits
napetrov 614dbc2
Address review: a harness that exits nonzero before any trace is a crash
napetrov ff47728
test, docs: pin the retry of a crashed cell and the timed-out no-trac…
napetrov b6d3906
Merge branch 'main' of https://github.com/intel/dokimi into r6/pr810
napetrov 5aa80f3
Address review: a harness that prints a trace line before its crash k…
napetrov 75d8d0a
Address review: qualify the docker-failure exit 5 promise
napetrov cfcf8c2
test: move the crash-trace tests out of test_repo_run.py
napetrov 36c6bb4
Address review: the newer docker CLI's daemon diagnostic is a docker …
napetrov 31f6874
Address review: the CI notes on test_repo_run.py are already fixed
napetrov a7f0f1d
Merge branch 'main' of https://github.com/intel/dokimi into pr810-r10
napetrov 5331a4f
Address review: match docker 29 permission-denied on the API
napetrov d055361
Address review: --strict names the NOT MEASURED arms too
napetrov 3325ac9
Address review: the docs name the crash and the --strict exit codes
napetrov 21e30b4
Tidy after the self-review: a stale comment, an always-true branch, o…
napetrov 8f61f29
Address review: the items of the review at 31f6874 are fixed in the c…
napetrov 8d745aa
docs(repo): a crash before the first trace line charges its cap; pin …
napetrov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
dokimi/changelog.d/20261115_120000_napetrov_fix_cli-a2b5-exits.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!-- | ||
| Copyright (C) 2026 Intel Corporation | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| --> | ||
|
|
||
| ### Changed | ||
|
|
||
| - **Exit codes for the cases below** — scripts that branch on the exit code see these changes: | ||
| - `dokimi repo run`: a cell that crashes (a harness that exits nonzero before its first trace line, unless the cap killed it, a docker daemon or CLI failure that stops the agent, a scratch directory that vanished, a result that cannot be written) exits 5 (infra failure); it exited 1 before, and a harness that exited nonzero with no trace exited 0 (its cell was recorded as a fail). Such a cell writes no `result.json`, so the next run runs it again. A failure after the agent ran (a docker failure while the grader runs, or a host-side error in grading) is not a crash: its cell keeps `result.json` with a failed grade. A cell refused on its inputs (for example a malformed `.mcp.json`), a budget stop or a failed host probe still exits 1. | ||
| - `dokimi eval judge agreement --strict` exits 3 (inconclusive) when an arm is NOT MEASURED or no arm can be compared, and 4 (invalid) when an arm is JUDGE-DEPENDENT; it exited 1 for both before. Without `--strict` the exit code is unchanged (0), and a judge that scored none of its answers still exits 1. | ||
| - `dokimi trace inspect`, `dokimi trace consistency` exit 2 (bad input) when no trace can be read; they exited 1 before. With `--json` they print the `input` error document (`error.code` `input`, `data` null) instead of a document with `status` `failed`. A partial read still exits 1. | ||
| - **A crash before the first trace line charges its full cap to the batch budget** — its spend is unknown, so `repo run` charges the cell's `budget_usd` to `_eval/spend.json` (as a killed harness does), and each rerun charges it again. A batch with `--max-batch-usd` counts the crashes toward that cap, so fix the harness before a rerun. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.