Repository navigation
feat(novelty): ground identifier vetoes in C headers and library symbols #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
napetrov
wants to merge
19
commits into
intel:main
Choose a base branch
from
napetrov:feat/ground-symbols
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+955
−38
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8518e53
feat(novelty): ground answers on a C API's names from its headers and…
napetrov 5b79668
fix(novelty): refuse an empty prefix list and an unreadable header as…
napetrov 57f29fa
fix(novelty): keep a tool named symbols apart from the symbol check; …
napetrov 7fc1317
fix(novelty): a symbol check per prefix set, so a re-run with other p…
napetrov 63b3d01
Merge branch 'main' of https://github.com/intel/dokimi into pr811-gro…
napetrov 74acda7
fix(novelty): read existing header paths, C comment splices, dash-nam…
napetrov d04342d
docs(novelty): say which header names a symbol check reads
napetrov 8057fca
Merge branch 'main' of https://github.com/intel/dokimi into pr811-gro…
napetrov 1d5ef97
Address review: symbol checks overlap by prefix, and operator-adjacen…
napetrov 9f03f9b
Address review: a called API name may have whitespace before its paren
napetrov 494a4fe
Merge branch 'main' of https://github.com/intel/dokimi into pr811-gro…
napetrov 3e5ed8d
Address review: keep the broader prefix check on a nested refresh
napetrov 989b9f5
Address review: keep the symbol checks sound on refresh and parsing
napetrov 40c8061
Merge branch 'main' of https://github.com/intel/dokimi into pr811-gro…
napetrov 0691210
Address review: --shared-lib names the library; ground no longer take…
napetrov 1f10991
fix(novelty): read a name after a spaced minus as an API name
vchamarthi e54905c
Merge remote-tracking branch 'intel/main' into feat/ground-symbols
napetrov 32f03a7
fix(novelty): a link context is no veto under a shared prefix
napetrov 294023d
fix(novelty): a refresh keeps the link exemption of the check it merg…
napetrov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
dokimi/changelog.d/20261115_120000_napetrov_novelty-ground-c-api-names.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| ### Added | ||
|
|
||
| - **`skill novelty ground` vetoes C API names** — `--header PATH` (glob ok) and `--shared-lib PATH` | ||
| (a shared library, read with `nm -D --defined-only`), each repeatable, with `--prefix cblas_` | ||
| (a C identifier ending in `_`, repeatable). An answer naming a prefixed name no header declares | ||
| and no library exports (`cblas_dgemmx`) is vetoed without a judge, and `meta.key_status` is | ||
| `not_found` for a key that names one. Each input is pinned by its sha256. A `--header` or | ||
| `--shared-lib` set with no prefixed name is refused, and `--prefix` needs one of them. No MKL | ||
| install is needed: any header set or shared library of the API works. |
13 changes: 13 additions & 0 deletions
13
dokimi/changelog.d/20261117_170000_napetrov_novelty-ground-link-context.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <!-- | ||
| Copyright (C) 2026 Intel Corporation | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| --> | ||
|
|
||
| ### Fixed | ||
|
|
||
| - **`skill novelty ground --prefix mkl_` no longer vetoes library names in a link context** — `Link with | ||
| mkl_intel_lp64, mkl_sequential and mkl_core.`, `Use the mkl_rt single dynamic library.` and | ||
| `target_link_libraries(app MKL::mkl_core)` were refused as "not in source". A name after `-l` or `::`, | ||
| or in a sentence about linking or a library, is not vetoed, and a library file's stem (`mkl_rt` for | ||
| `libmkl_rt.so`) is a known name. A called name (`mkl_x(`) is still vetoed, and so is an undeclared name | ||
| outside a link context (`Call mkl_x to set threads`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
--prefix mkl_, a correct link instruction is vetoed: library names share the prefix but are no symbols.With a header declaring
mkl_set_num_threads:Link with mkl_intel_lp64, mkl_sequential and mkl_core.→not in source: mkl_intel_lp64, mkl_sequential, mkl_coreUse the mkl_rt single dynamic library.→not in source: mkl_rttarget_link_libraries(app MKL::mkl_core)→not in source: mkl_coreNo
--libraryexports a symbol named after itself, and the tests usemkl_as a prefix.Suggestion: say in the docs that a prefix must not be shared with library or file names (
mkl_sparse_,cblas_, notmkl_), with the link sentence as a test; or skip names in a link context (-l,::, afterlink).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on a decision before I change this: fix the
--prefix mkl_link veto in the docs (a) or in code (b)? My recommendation: (a), a rule that a prefix must not be shared with library or file names, with the link sentence as a test. The thread stays open until then.