Repository navigation
docs: remove three unreferenced README images - #819
Merged
antonwolfy merged 1 commit intoNov 16, 2026
Merged
Conversation
Settles the review point on intel#627 (B2.1) that `annotated-skill.png`, `shortening-strategies.png` and `three-questions.png` in `dokimi/docs/assets/readme/` are orphaned. `git grep` for each name and stem across the tree (docs, README, mkdocs.yml, tests) finds no reference, so the three files are deleted with no other change. Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
+ Coverage 95.76% 95.77% +0.01%
==========================================
Files 416 416
Lines 55624 55624
Branches 9553 9553
==========================================
+ Hits 53267 53275 +8
+ Misses 1456 1449 -7
+ Partials 901 900 -1 🚀 New features to boost your workflow:
|
vchamarthi
approved these changes
Nov 16, 2026
vchamarthi
left a comment
Contributor
There was a problem hiding this comment.
🟢 Approved · reviewed f61bf57
Next: nothing required from @antonwolfy.
Verified on f61bf57: ✅ full suite with main merged in: 22216 passed · ✅ merges onto main
6 checks behind it, each with its evidence
| Area | What holds | How |
|---|---|---|
| Deleted images | The diff changes only annotated-skill.png, shortening-strategies.png and three-questions.png under dokimi/docs/assets/readme/, and all three are gone on the head |
ran it |
| References | No file on the head names annotated-skill, shortening-strategies or three-questions, so the deletion breaks no doc link, mkdocs build or test |
ran it |
| Size | The three PNGs total 527,148 bytes on main (127,061 + 273,522 + 126,565), as the description says | ran it |
| Changelog fragment | The changed paths sit outside dokimi/dokimi/, dokimi/data/ and the [project] table, so no changelog fragment is required, as the description says |
ran it |
| Docs and tests | make ci-local passes with main merged in: mkdocs build passes and 22216 tests pass with none failing |
full suite, main merged in |
| Merge | The PR merges onto current main with no conflict | merge onto main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the review of #627, where three images in
dokimi/docs/assets/readme/were noted as orphaned (review).On
main(d92be0c),git grepforannotated-skill,shortening-strategiesandthree-questionsfinds no reference in docs,README.md,mkdocs.ymlor tests, yet the three PNGs are in the tree.Changes
dokimi/docs/assets/readme/annotated-skill.png,shortening-strategies.pngandthree-questions.png; together they were 527,148 bytes (127,061 + 273,522 + 126,565).dokimi/dokimi/,dokimi/data/and[project].Risk
None: nothing references the files, and the docs build and link tests pass.
Testing
On a Linux review host, at
f61bf57(onmaind92be0c):make ci-local: 31 passed, 2 failed, 14 skipped. The two failures areInstall gitleaks(the download returned HTTP 504) andScan commits, which needs that binary; no scan ran. The skipped steps are the matrix legs on other Pythons, jobs that only run on other events, and checks needing tools not on the host (micromamba, semgrep). The full suite had 21732 passed, 19 skipped;mkdocs build, mypy, ruff, bandit and pre-commit pass.tests/test_docs_links.pyandtests/test_docs_code_refs.py: 75 passed.Open questions
None.
Revert
A plain revert restores the three images. Nothing is stored.
Checklist
pytestpasses (N/A: no tests changed; the full suite passes)ruff,mypy, and schema checks passAGENTS.mdraise/exit and test names the doc, contract or issue it traces to.github/.licenserc.yaml)