Skip to content

Fix dotnet test: remove explicit Compile item from .csproj - #1055

Merged
mlim19 merged 2 commits into
masterfrom
fix_dotnet_test_failure
Oct 5, 2026
Merged

mlim19 merged 2 commits into
masterfrom
fix_dotnet_test_failure

Conversation

@mlim19

@mlim19 mlim19 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

The Microsoft.NET.Sdk automatically discovers and compiles .cs files in the project directory. The explicit ItemGroup was causing conflicts with newer .NET SDK versions in GitHub Actions runners.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the relevant documentation.
  • I have added tests for new logic.

The Microsoft.NET.Sdk automatically discovers and compiles .cs files
in the project directory. The explicit ItemGroup was causing conflicts
with newer .NET SDK versions in GitHub Actions runners.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 21:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change correctly prevents duplicate compile-item conflicts while preserving source discovery.

Review effort: Balanced
Findings: None

What changed in this PR

Removes redundant explicit C# compilation configuration to maintain compatibility with newer .NET SDKs.

Changes:

  • Relies on SDK default .cs file discovery.
  • Updates the explanatory comment.
File Description
tests/​conftest.py Simplifies the generated test project file.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

gmunoz
gmunoz previously approved these changes Sep 30, 2026
Copilot AI balanced review requested due to automatic review settings October 1, 2026 21:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 High severity

Open (1)

Comment thread scripts/fix_centos7.sh Resolved
Copilot AI balanced review requested due to automatic review settings October 1, 2026 22:06
@mlim19
mlim19 force-pushed the fix_dotnet_test_failure branch from 618234f to 814753d Compare October 1, 2026 22:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: None

Resolved since last review (1)

@mlim19
mlim19 force-pushed the fix_dotnet_test_failure branch from 814753d to 02002c9 Compare October 1, 2026 23:06
Copilot AI balanced review requested due to automatic review settings October 1, 2026 23:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The CentOS rewrite can modify unrelated third-party repositories and is undocumented in the PR description.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)

Comment thread scripts/fix_centos7.sh Outdated
Comment on lines +17 to +20
sed -i 's|/centos/\$releasever/|/centos/7.9.2009/|g' /etc/yum.repos.d/*.repo
sed -i 's|/centos/7/|/centos/7.9.2009/|g' /etc/yum.repos.d/*.repo
sed -i 's|/altarch/\$releasever/|/altarch/7.9.2009/|g' /etc/yum.repos.d/*.repo
sed -i 's|/altarch/7/|/altarch/7.9.2009/|g' /etc/yum.repos.d/*.repo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporal workaround due to Centos7 EOL.

Comment thread scripts/fix_centos7.sh
Comment on lines +5 to +6
# CentOS 7 reached EOL; mirror.centos.org no longer serves the repos.
# Repoint every repo at the archive.kernel.org snapshot of CentOS 7.9.2009.
CentOS 7 reached EOL and mirror.centos.org no longer serves the repos.
Repoint all repos at the archive.kernel.org snapshot of CentOS 7.9.2009.

Three URL layouts are handled across the x86_64 and aarch64 images:
 - x86_64 base: mirror.centos.org/centos/$releasever/...
 - x86_64 SCLo: mirror.centos.org/centos/7/sclo/... (literal 7)
 - aarch64:     mirror.centos.org/altarch/7/... (literal 7, altarch path)

The release token ($releasever and literal 7) is normalised to 7.9.2009
before the host swap so each path maps to a valid archive URL:
 - archive.kernel.org/centos-vault/7.9.2009/...         (x86_64)
 - archive.kernel.org/centos-vault/altarch/7.9.2009/... (aarch64)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 2, 2026 00:03
@mlim19
mlim19 force-pushed the fix_dotnet_test_failure branch from 02002c9 to 5f55478 Compare October 2, 2026 00:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The substantial CentOS repository migration is undocumented and unrelated to the stated PR scope.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)

@mlim19
mlim19 merged commit 566a2cc into master Oct 5, 2026
57 of 58 checks passed
@mlim19
mlim19 deleted the fix_dotnet_test_failure branch October 5, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants