Repository navigation
Fix dotnet test: remove explicit Compile item from .csproj - #1055
Conversation
The Microsoft.NET.Sdk automatically discovers and compiles .cs files in the project directory. The explicit ItemGroup was causing conflicts with newer .NET SDK versions in GitHub Actions runners. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change correctly prevents duplicate compile-item conflicts while preserving source discovery.
Review effort: Balanced
Findings: None
What changed in this PR
Removes redundant explicit C# compilation configuration to maintain compatibility with newer .NET SDKs.
Changes:
- Relies on SDK default
.csfile discovery. - Updates the explanatory comment.
| File | Description |
|---|---|
tests/conftest.py |
Simplifies the generated test project file. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
618234f to
814753d
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: None
Resolved since last review (1)
814753d to
02002c9
Compare
| sed -i 's|/centos/\$releasever/|/centos/7.9.2009/|g' /etc/yum.repos.d/*.repo | ||
| sed -i 's|/centos/7/|/centos/7.9.2009/|g' /etc/yum.repos.d/*.repo | ||
| sed -i 's|/altarch/\$releasever/|/altarch/7.9.2009/|g' /etc/yum.repos.d/*.repo | ||
| sed -i 's|/altarch/7/|/altarch/7.9.2009/|g' /etc/yum.repos.d/*.repo |
There was a problem hiding this comment.
This is a temporal workaround due to Centos7 EOL.
| # CentOS 7 reached EOL; mirror.centos.org no longer serves the repos. | ||
| # Repoint every repo at the archive.kernel.org snapshot of CentOS 7.9.2009. |
CentOS 7 reached EOL and mirror.centos.org no longer serves the repos. Repoint all repos at the archive.kernel.org snapshot of CentOS 7.9.2009. Three URL layouts are handled across the x86_64 and aarch64 images: - x86_64 base: mirror.centos.org/centos/$releasever/... - x86_64 SCLo: mirror.centos.org/centos/7/sclo/... (literal 7) - aarch64: mirror.centos.org/altarch/7/... (literal 7, altarch path) The release token ($releasever and literal 7) is normalised to 7.9.2009 before the host swap so each path maps to a valid archive URL: - archive.kernel.org/centos-vault/7.9.2009/... (x86_64) - archive.kernel.org/centos-vault/altarch/7.9.2009/... (aarch64) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
02002c9 to
5f55478
Compare



The Microsoft.NET.Sdk automatically discovers and compiles .cs files in the project directory. The explicit ItemGroup was causing conflicts with newer .NET SDK versions in GitHub Actions runners.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots
Checklist: