fix: set general_profile_idc in bitstream when --profile is not speci…#386
Open
XinfengZhang wants to merge 1 commit intointel:masterfrom
Open
fix: set general_profile_idc in bitstream when --profile is not speci…#386XinfengZhang wants to merge 1 commit intointel:masterfrom
XinfengZhang wants to merge 1 commit intointel:masterfrom
Conversation
…fied When --profile is omitted, real_hevc_profile stays at its initial value of 0 even though hevc_profile is correctly auto-detected. This writes general_profile_idc=0 into VPS/SPS, producing a non-conformant HEVC bitstream that decoders reject with "Unknown HEVC profile: 0". Set real_hevc_profile to match the auto-detected VA-API profile in the init_va() switch block so the bitstream always contains the correct profile indicator. Signed-off-by: Carl.Zhang <carl.zhang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fied
When --profile is omitted, real_hevc_profile stays at its initial value of 0 even though hevc_profile is correctly auto-detected. This writes general_profile_idc=0 into VPS/SPS, producing a non-conformant HEVC bitstream that decoders reject with "Unknown HEVC profile: 0".
Set real_hevc_profile to match the auto-detected VA-API profile in the init_va() switch block so the bitstream always contains the correct profile indicator.