Skip to content

Bp enable disable - #22

Merged
clillies merged 1 commit into
intel:mainfrom
clillies:bp-enable-disable
Nov 16, 2026
Merged

clillies merged 1 commit into
intel:mainfrom
clillies:bp-enable-disable

Conversation

@clillies

@clillies clillies commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Fix disable/enable for breakpoints, dont delete and re-create.

@clillies
clillies requested a review from aragners November 5, 2026 23:47
@clillies
clillies requested a review from a team as a code owner November 5, 2026 23:47
@aragners

aragners commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

This PR contains other commits that have not been committed. So cannot be approved without those being committed first or doing a rebase without being based on commits that are part of other PRs

aragners
aragners previously approved these changes Nov 9, 2026

@aragners aragners left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out with manual investigation of breakpoints and seems good. Looks better this way from TCF protocol perspective, although I guess not fully necessary.

@aragners

Copy link
Copy Markdown
Contributor

This is an empty commit now

Unchecking a breakpoint in VS Code removed it from the TCF agent, and
checking it again added it back with a new ID. The Breakpoints service
has enable and disable commands for this, so use them and keep the
breakpoint in the agent.

DAP has no enabled flag. VS Code leaves a disabled breakpoint out of
the next set*Breakpoints request, the same as a deleted one. The
extension API still lists disabled breakpoints, so the adapter checks
that list: breakpoints still in it are disabled, the others removed.

VS Code does not show instruction breakpoints to extensions, so these
are still removed when unchecked. Deactivating all breakpoints in VS
Code now disables them in the agent, as VS Code still lists them.

Signed-off-by: Claes Lillieskold <claes.lillieskold@intel.com>
@clillies
clillies merged commit 82a1035 into intel:main Nov 16, 2026
5 checks passed
@clillies
clillies deleted the bp-enable-disable branch November 16, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants