Skip to content

Improve symbol file picker - #30

Merged
MagnusIntel merged 2 commits into
intel:mainfrom
MagnusIntel:fix-symbol-file-picker
Nov 9, 2026
Merged

MagnusIntel merged 2 commits into
intel:mainfrom
MagnusIntel:fix-symbol-file-picker

Conversation

@MagnusIntel

@MagnusIntel MagnusIntel commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Improve the file picker for symbol files, see #29

Fixes #29

Signed-off-by: Magnus Andersson <magnus.andersson@intel.com>
@MagnusIntel
MagnusIntel requested a review from a team as a code owner November 9, 2026 11:23
aragners
aragners previously approved these changes Nov 9, 2026

@aragners aragners left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase on recent changelog updates, but what you showed looked good.

Signed-off-by: Magnus Andersson <magnus.andersson@intel.com>

@aragners aragners left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer rebase over merge commit in PR for nicer git history. But approved anyway.

@MagnusIntel
MagnusIntel merged commit e1010fd into intel:main Nov 9, 2026
5 checks passed
@MagnusIntel
MagnusIntel deleted the fix-symbol-file-picker branch November 9, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The file picker when adding symbols files lacks standard features

2 participants