merge coverage across llvm-cov data[] entries#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates llvm-cov JSON parsing so coverage is aggregated across multiple data[] entries (one per profiled binary), avoiding double-counting denominators when the same source file/function appears in multiple binaries.
Changes:
- Aggregate per-file
segmentsacross alldata[]entries before computing line/region coverage. - Aggregate
functionsacross alldata[]entries before merging instantiations and computing function coverage. - Add fixtures and tests covering multi-binary merging and segment-merging behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/parse-llvm-cov-json.test.mjs | Adds a regression test ensuring coverage is merged across multiple data[] entries. |
| tests/merge-segments-across-entries.test.mjs | Adds unit tests for the new cross-entry segment merge helper. |
| tests/fixtures/multi-binary-llvm-cov.json | Adds an llvm-cov JSON fixture representing two binaries reporting the same file. |
| src/parse-llvm-cov-json.mjs | Refactors parsing to collect/merge segments and functions across all data[] entries. |
| src/merge-segments-across-entries.mjs | Introduces helper to merge segments by position across multiple entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.