Skip to content

CommonJS model: commonJsEvidenceFiles cuts off at 8 files visited while forwardsOutside reads to depth 8 #41

Open

Description

@inth3shadows

Found in the round-1 review of branch fix/commonjs-model-gaps (stacked on PR #29). This is a hypothesis; no edge difference has been shown.

commonJsEvidenceFiles still stops at seen.size >= 8, while forwardsOutside now cuts off on path depth (8) after #32. For a chain of exactly 8 forwarding hops, the forward check reads the 9th file, but that file is missing from typeFrom (import-resolver.ts, the commonJs typeFrom branch). That can leave a dependency the incremental sync does not track.

Fix direction: use the same depth cutoff in both.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions