Repository navigation
Unblock CI for clippy 1.100 and RUSTSEC-2026-0486 - #133
Merged
Merged
Conversation
Clippy 1.100 adds a needless_bool check for an if guard followed by a bool literal; collapse looks_like_prompt_echo_prefix's tail to a negated matches!. Bump rustix 1.1.4 -> 1.1.6 (dev-only, via tempfile) to clear the unsound xattr advisory that cargo audit --deny warnings now rejects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on #132 failed for two reasons unrelated to that diff; both now fail on main too.
needless_boolcheck (if guard returning a bool literal, followed by another). Collapsedlooks_like_prompt_echo_prefixtail insrc/highlight.rsto!matches!(...). No behavior change.rustix1.1.4, unsound xattr zero-length buffer) tripscargo audit --deny warnings. Bumped torustix1.1.6 inCargo.lock.rustixarrives only throughtempfile(dev-dependency); the shipped binary does not link it, so no release needed.Local (rustc 1.100.0):
cargo fmt --check,cargo clippy --locked --all-targets --all-features -- -D warnings,cargo audit --deny warnings,cargo test --lockedall pass.