Skip to content

Close two gaps in the 1.3.1 fixes - #136

Merged
inxbit merged 1 commit into
mainfrom
fix/review-followups
Nov 17, 2026
Merged

inxbit merged 1 commit into
mainfrom
fix/review-followups

Conversation

@inxbit

@inxbit inxbit commented Nov 17, 2026

Copy link
Copy Markdown
Owner

A review of #134 before tagging found two fixes that were incomplete. Both have a test that failed first.

  • --local-echo: the new SS3 handling took any byte after ESC O for the end of the key, so Escape, O, Enter typed in turn lost the echoed line break. Only a final byte (@ to ~) completes the key.
  • generic profile: the bad-state rule accepted not followed by up to two mixed separators, while the good-state rule excluded only four exact forms, so not + space + tab, or three spaces, still painted connected green. The good-state rule now skips a good word after not and spacing of any length, and the bad-state rule accepts the same spacing.

Throughput on a 1.6 MB capture is unchanged against 1.3.0.

- --local-echo took any byte after `ESC O` for the end of an SS3 key, so
  Escape, `O`, Enter typed in turn lost the echoed line break. Only a
  final byte completes the key now.
- generic: the red `not connected` rule accepted spacing the green rule
  did not exclude, so `not` plus a space and a tab, or three spaces,
  still left `connected` green. The good-state rule now skips any good
  word that follows `not` and spacing of any length.
@inxbit
inxbit merged commit b06bb1e into main Nov 17, 2026
4 checks passed
@inxbit
inxbit deleted the fix/review-followups branch November 17, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant