Repository navigation
Close two gaps in the 1.3.1 fixes - #136
Merged
Merged
Conversation
- --local-echo took any byte after `ESC O` for the end of an SS3 key, so Escape, `O`, Enter typed in turn lost the echoed line break. Only a final byte completes the key now. - generic: the red `not connected` rule accepted spacing the green rule did not exclude, so `not` plus a space and a tab, or three spaces, still left `connected` green. The good-state rule now skips any good word that follows `not` and spacing of any length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review of #134 before tagging found two fixes that were incomplete. Both have a test that failed first.
--local-echo: the new SS3 handling took any byte afterESC Ofor the end of the key, so Escape,O, Enter typed in turn lost the echoed line break. Only a final byte (@to~) completes the key.notfollowed by up to two mixed separators, while the good-state rule excluded only four exact forms, sonot+ space + tab, or three spaces, still paintedconnectedgreen. The good-state rule now skips a good word afternotand spacing of any length, and the bad-state rule accepts the same spacing.Throughput on a 1.6 MB capture is unchanged against 1.3.0.