Open
Conversation
gyurix
reviewed
Apr 16, 2026
gyurix
left a comment
gyurix
left a comment
There was a problem hiding this comment.
Not mergeable in current form.
This patch leaves broken ternary expressions in both installer and uninstaller (k == 0 ? "7-Zip File Manager.lnk" :) with no else branch, so it does not compile.
Even after syntax fix, this is a product/UX change mixed straight into installer logic without much rationale.
Merge readiness: 0/10. Before merge: fix syntax first, decide desired Start Menu behavior explicitly, and separate UX decision from code cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the Windows Start Menu entry by removing the help link (this is not the right place to put it, and it is still findable under Apps & Programs) and placing the shortcut directly into the Start Menu, without a folder that requires a click to expand. This follows more modern practices and cleans up the UX a little.
I cannot find any documentation for contributing/building, please reach out if I did anything wrongly.