Fix path export command in source installation guide#5062
Fix path export command in source installation guide#5062linzhu-dot wants to merge 1 commit intoisaac-sim:mainfrom
Conversation
ISAACSIM_PATH is wrong because ${pwd} is empty; only $PWD or $(pwd) or ${PWD} work.
Signed-off-by: linzhu-dot <linzhu@nvidia.com>
Greptile SummaryThis PR fixes a shell syntax error in the source installation guide where
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User runs source installation guide] --> B["export ISAACSIM_PATH=..."]
B --> C{Shell syntax used?}
C -- "Before fix: \${pwd}" --> D["Variable expansion for 'pwd'\n(undefined variable)"]
D --> E["ISAACSIM_PATH = '/_build/linux-x86_64/release'\n(empty prefix — broken path)"]
C -- "After fix: \$(pwd)" --> F["Command substitution:\nruns the pwd command"]
F --> G["ISAACSIM_PATH = '/home/user/isaaclab/_build/linux-x86_64/release'\n(correct full path)"]
G --> H["export ISAACSIM_PYTHON_EXE=\${ISAACSIM_PATH}/python.sh"]
E --> I["export ISAACSIM_PYTHON_EXE fails — path is wrong"]
Last reviewed commit: "Fix path export comm..." |
There was a problem hiding this comment.
Review: PR #5062 — Fix path export command in source installation guide
✅ LGTM — Correct fix.
The change from ${pwd} → $(pwd) is valid. In bash, ${pwd} attempts variable expansion on a variable named pwd (which is unset, so it expands to an empty string), while $(pwd) performs command substitution, correctly executing the pwd command and returning the current working directory.
Verified by testing both forms in a shell:
${pwd}→""(empty)$(pwd)→/current/working/directory✓
The resulting ISAACSIM_PATH would have been set to just /_build/linux-x86_64/release (absolute from root!) instead of the intended relative-to-cwd path, which would break the subsequent Isaac Sim verification steps.
One minor note: ${PWD} (uppercase) would also work since PWD is a built-in shell variable, but $(pwd) is a perfectly standard and clear approach.
Single file changed, doc-only fix, CI passing. Good to merge.
ISAACSIM_PATH is wrong because ${pwd} is empty; only$PWD or $ (pwd) or ${PWD} work.
Type of change