Verify primary PID is still alive before assuming it is running#217
Open
chen3feng wants to merge 2 commits into
Open
Verify primary PID is still alive before assuming it is running#217chen3feng wants to merge 2 commits into
chen3feng wants to merge 2 commits into
Conversation
When a primary instance is force-killed (SIGKILL), the shared memory block persists with `primary=true` and the stale PID. Previously this caused all subsequent launches to detect a non-existent primary and immediately exit as secondary instances. Now we check if the recorded primaryPid actually corresponds to a running process via kill(pid, 0) on Unix or OpenProcess() on Windows. If the PID is gone, we take over as the primary instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a primary instance is force-killed (SIGKILL), the shared memory block persists on Unix systems with
primary=trueand the stale PID. Currently this causes all subsequent launches to detect a non-existent primary and immediately exit as secondary instances.This PR adds an
isProcessRunning()check after the shared memory checksum verification. If the recordedprimaryPidno longer corresponds to a running process:kill(pid, 0)+errno != ESRCHOpenProcess()+GetExitCodeProcess()The new instance then takes over as primary instead of exiting.
Tested on macOS (force-kill scenario) and confirmed the stale PID warning is now followed by successful takeover.