Improve dismissing ScrollView

[dstranz]

• Support swipe in UIViewController embedded in UINavigationController
• Fix position of UITableView header view - reason: applying transformation to tableHeaderView itself - as one of scrollView.subviews doesn't work as expected, it need's to be applied to header view content

[ivanvorobei]

You can attach gif or video with bug which you fix?

[dstranz]

Fix position of UITableView header view - reason: applying transformation to tableHeaderView itself - as one of scrollView.subviews doesn't work as expected, it need's to be applied to header view content

[dstranz]

Support swipe in UIViewController embedded in UINavigationController

This one is a code only bug. When you are showing UITableViewController embedded in UINavigationController it's not possible to dismiss it with swipe.

[Tavernari]

Support swipe in UIViewController embedded in UINavigationController

This one is a code only bug. When you are showing UITableViewController embedded in UINavigationController it's not possible to dismiss it with swipe.

Hi, I am facing to this issue and I created a PR just for this case

Could you test this Pull Request? #77

Maybe it'll resolve this issue.

Best

[dstranz]

@Tavernari Nope, it doesn't helped when I'm showing UITableViewController embedded in UINavigationViewController as Stork view.

If I have only UITableViewController presented as Stork view it works fine but it works without your PR also. It only needs to add:
func scrollViewDidScroll(_ scrollView: UIScrollView) { SPStorkController.scrollViewDidScroll(scrollView) }
as mentioned in Readme.

[ivanvorobei]

@dstranz you can attach simple project with bug?
I am added header view and for me all work correctly.
I need see how it bug create
Thanks!

[dstranz]

@ivanvorobei I've added this code

let headerView = UIView(frame: .init(x: 0, y: 0, width: tableView.frame.height, height: 100))
headerView.backgroundColor = .red
tableView.tableHeaderView = headerView

to viewDidLoad() in ModalTableViewController.swift in Stork demo app.

[ivanvorobei]

@dstranz thanks!
I am added it, also apply your changes, but bug actual. See code and simulator preview:

[dstranz]

@ivanvorobei OK, sorry. I wasn't precise. I haven't got any idea how to move headerView itself. That's the reason why I apply transformations to tableHeaderView.subviews.

But I will be of course the best to move tableHeaderView itself if we would know how to do that.

[ivanvorobei]

@dstranz I just see that this does not fix the situation. If this helped you, check if you have added any changes. So far, what I see is not working

[dstranz]

@ivanvorobei That's the code that could replicate my case - for it my fix helps:

        let headerView = UIView(frame: .init(x: 0, y: 0, width: tableView.frame.height, height: 100))
        headerView.backgroundColor = .clear
        
        let testView = UIView(frame: headerView.frame)
        testView.backgroundColor = .red
        testView.translatesAutoresizingMaskIntoConstraints = false
        headerView.addSubview(testView)
        
        NSLayoutConstraint.activate([
            headerView.leadingAnchor.constraint(equalTo: testView.leadingAnchor),
            headerView.trailingAnchor.constraint(equalTo: testView.trailingAnchor),
            headerView.topAnchor.constraint(equalTo: testView.topAnchor),
            headerView.bottomAnchor.constraint(equalTo: testView.bottomAnchor),
        ])
        
        tableView.tableHeaderView = headerView

But it will be better to find better solution to move whole tableHeaderView - if you know how to move it ;)

[dstranz]

@ivanvorobei I've just found a better solution for this issue, just transform whole UIScrollView:
scrollView.transform = CGAffineTransform(translationX: 0, y: -translation)

It works fine with #79 (comment) and #79 (comment)

[dstranz]

[ivanvorobei]

@dstranz it work and I am merged

but problem with scroll indicator.... incorrect top inset. When I am use translation for each subviews, scroll save position and not change indicator inset.

Now indicator translate with scroll..

[ivanvorobei]

I also found a critical bug. If you use this code, a white area will appear from below if you pull the controller down. It is very strange.

While I returned the old version.

See screenshoot :

[dstranz]

@ivanvorobei Sorry, I didn't found that while testing (but it's also visible on my gif).

Do you have any idea how to fix tableHeaderView bug without adding this white space on the bottom?

[ivanvorobei]

@dstranz now I recommended create custom table view cell.

In next... I am try found solution

[iammxrn]

Hi! Any updates?