Skip to content

Fix getstring bug #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackBonadies merged 3 commits into from
May 2, 2026
Merged

Fix getstring bug #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03ed762
fix searchfragment getString bug.
jackBonadies May 2, 2026
fc9485f
add mock for 1results
jackBonadies May 2, 2026
75e57c5
bump version to 3.4.1 (124)
jackBonadies May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Common/MockSoulseekClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,7 @@ private static List<SearchResponse> MakeChipResponses(int resolvedToken, string
bool isChipTestOther = joinedTerms.Contains("chiptest") && joinedTerms.Contains("other");
bool isSlowSearch = joinedTerms.Contains("slowsearch");
bool is0Results = joinedTerms.Contains("0results");
bool is1Results = joinedTerms.Contains("1results");
bool isCurated = isBeethovenOverture || isChipTestOther;

var allResponses = new List<SearchResponse>();
Expand Down Expand Up @@ -1222,6 +1223,15 @@ private static List<SearchResponse> MakeChipResponses(int resolvedToken, string
{
await Task.Delay(10000).ConfigureAwait(false);
}
else if (is1Results)
{
await Task.Delay(8000).ConfigureAwait(false);
var response = GenerateMockSearchResponse(resolvedToken, search);
allResponses.Add(response);
var currentSearch = new Soulseek.Search(query, resolvedScope, resolvedToken, SearchStates.InProgress, 1, 0, 0);
options?.ResponseReceived?.Invoke((currentSearch, response));
await Task.Delay(2000).ConfigureAwait(false);
}
else
{
if (isSlowSearch)
Expand Down
2 changes: 1 addition & 1 deletion Seeker/Properties/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="123" android:versionName="3.4.0" package="com.companyname.andriodapp1" android:installLocation="auto" android:requestLegacyExternalStorage="true">
<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="124" android:versionName="3.4.1" package="com.companyname.andriodapp1" android:installLocation="auto" android:requestLegacyExternalStorage="true">
<application android:allowBackup="true" android:icon="@mipmap/ic_launcher" android:label="@string/app_name" android:supportsRtl="false" android:enableOnBackInvokedCallback="true" android:theme="@style/AppTheme" android:name="com.companyname.Seeker.SeekerApplication" android:localeConfig="@xml/locales_config">
<service android:name="com.companyname.Seeker.DownloadService" android:stopWithTask="true"></service>
<service android:name="com.companyname.Seeker.SeekerKeepAliveService"></service>
Expand Down
5 changes: 3 additions & 2 deletions Seeker/Search/SearchFragment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ public void UpdateNoResultsView()
if (show && noResultsSubtitle != null)
{
noResultsSubtitle.Text = string.Format(
GetString(Resource.String.no_results_subtitle),
SeekerApplication.GetString(Resource.String.no_results_subtitle),
SearchTabHelper.LastSearchTerm ?? string.Empty);
}
noResultsView.Visibility = show ? ViewStates.Visible : ViewStates.Gone;
Expand All @@ -670,7 +670,7 @@ public void UpdateAllFilteredView()
if (show && allFilteredTitle != null)
{
allFilteredTitle.Text = string.Format(
GetString(Resource.String.results_hidden_title),
SeekerApplication.GetString(Resource.String.results_hidden_title),
total);
}
allFilteredView.Visibility = show ? ViewStates.Visible : ViewStates.Gone;
Expand Down Expand Up @@ -1808,6 +1808,7 @@ public override void OnPause()
base.OnPause();
PreferencesManager.SaveSearchFragmentFilterState(PreferencesState.FilterSticky, SearchTabHelper.TextFilter.FilterString, (int)PreferencesState.SearchResultStyle, ExpandAllResults);
StopWishlistBannerTicker();
StopSpinnerTimer();
}

private static void Actv_KeyPressHELPER(object sender, View.KeyEventArgs e)
Expand Down
Loading