feat(ui): rewrite Show-Logo with PS5.1 VT support#57
Merged
Conversation
…Invoke-Locksmith2 - rewrite Show-Logo.ps1 with native VT processing support for PS5.1 conhost, removing reliance on ANSI rendering that only worked in PS7+ - remove Show-Logo call from Invoke-Locksmith2; logo now runs at module import time as a standalone script, not on every function invocation - remove PwshSpectreConsole from Build-Module.ps1 IgnoreModuleName list as it is no longer a build-time dependency - bump ModuleVersion to 2026.5.90728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites
Show-Logoto work correctly on both PS5.1 (conhost + WindowsTerminal) and PS7+, and removes the logo from
Invoke-Locksmith2sinceit now runs at module import time.
Changes
Private/UI/Show-Logo.ps1: Complete rewrite with native VTprocessing support. PS5.1 conhost requires explicitly enabling virtual
terminal processing on the stdout handle before ANSI escape sequences
render correctly; the old implementation assumed PS7+/Windows Terminal
and produced garbled output (
â–ˆinstead of█) in PS5.1.Public/Invoke-Locksmith2.ps1: RemovedShow-Logocall. Logonow executes once at module import time as a standalone script rather
than on every
Invoke-Locksmith2invocation.Build/Build-Module.ps1: RemovedPwshSpectreConsolefromIgnoreModuleNamelist — no longer a build-time dependency.Locksmith2.psd1: Version bump to2026.5.90728.