fix(dashboard): embed logo as base64 data URI for portable HTML output#64
Merged
Conversation
- replace \ (absolute filesystem path) with \ (data URI) - base64-encode PNG bytes via [System.IO.File]::ReadAllBytes + [System.Convert]::ToBase64String - logo resolution candidates unchanged; encoding happens inside the loop on first match - drop -DisableCache from New-HTMLImage (irrelevant for data URIs) - bump ModuleVersion to 2026.5.121323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard HTML was embedding the logo as an absolute local filesystem path (
src="C:\Users\...\Images\Locksmith2.png"), making the output non-portable — the image would not render on any machine other than the one that generated the report.Changes
[System.IO.File]::ReadAllBytesand encode via[System.Convert]::ToBase64Stringdata:image/png;base64,...URI as the image source instead of the file path-DisableCachefromNew-HTMLImage(not applicable to data URIs)ModuleVersionto2026.5.121323Result
Dashboard HTML files are now fully self-contained — the logo renders correctly when opened on any machine, sent via email, or archived.
Testing
Invoke-Locksmith2; New-LS2Dashboardsrc="data:image/png;base64,..."instead of a filesystem path