Repository navigation
fix(metrics): local users could exhaust the daemon's file descriptors - #143
Merged
Merged
Conversation
The metrics endpoint accepted connections without limit, and each could sit for the 5 s header timeout. About 200 a second from any local user kept the daemon at its 1024-descriptor limit, which also stopped the control socket and the sinks. Close any connection past 16 open ones. This is F2 in docs/security-review.md. Signed-off-by: James Conway <148910373+jamesconwaydev@users.noreply.github.com>
j-dahl7
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F2 in
docs/security-review.md. The metrics endpoint had no connection limit, so any local user could hold connections open (5 s each) until the daemon hit its 1024 fd limit, taking the control socket and sinks down with it. The server now closes any connection past 16 open ones.The new test opens two idle connections against a cap of 2 and checks the third is closed at once (on
mainit waits for the header timeout and the test times out), then that a scrape works once they're gone. Off by default, so only hosts withmetrics.enabled = truewere exposed. #127 still covers aborting a connection that stops reading.