Repository navigation
docs(contributing): review asked the backup to approve every maintainer PR - #150
Merged
Merged
Conversation
…er PR The backup maintainer is there for continuity, not day-to-day review. Maintainer PRs now get their second reader once per release: the backup reviews the release PR, which carries every change since the last tag, and the tag waits for that approval. Security fixes can ship first and be reviewed afterwards. Signed-off-by: James Conway <148910373+jamesconwaydev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backup maintainer is there for continuity, not day-to-day review. This moves the maintainer's second reader to release time: the backup reviews the release PR, which carries every change since the last tag, and the tag waits for that approval. Contributor PRs are still reviewed by the maintainer before they merge. Security fixes can ship first and be reviewed afterwards.