Repository navigation
docs(governance): backup maintainer reviewed only the release PR - #155
Merged
Merged
Conversation
foothillsdigital takes over as backup maintainer from j-dahl7 and reviews every maintainer PR before it merges, not just the release PR. Security fixes still ship first and get reviewed afterwards. Signed-off-by: James Conway <148910373+jamesconwaydev@users.noreply.github.com>
foothillsdigital
approved these changes
Nov 15, 2026
foothillsdigital
left a comment
Collaborator
There was a problem hiding this comment.
Read e0ff4f0 against the checklist under Code review:
- Worth having: yes. It moves the second read from release time to every maintainer PR, which is stricter than before.
- Tested: docs only, nothing to test.
- Safe: nothing here touches a host or the SELinux module.
- Small: three lines, all on the one change. The Releases paragraph is updated to match ("like any other maintainer PR"), so the two sections don't disagree.
- The words match: the Roles table, Code review and Releases now say the same thing.
The Protect main ruleset asks for one approval and doesn't require a code owner, so the rule as written works as is. One small thing for later: .github/CODEOWNERS is * @jamesconwaydev, so GitHub auto-requests the author on the maintainer's own PRs and the backup has to be added by hand each time. Adding @foothillsdigital there would route those requests automatically. GOVERNANCE.md's line that CODEOWNERS "routes every review to the maintainer" would then want updating too.
Approving.
…digital Signed-off-by: James Conway <148910373+jamesconwaydev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@foothillsdigital takes over from @j-dahl7 as backup maintainer. Thanks for stepping in.
What changes:
This is also the first PR under the new rule, so it needs your approval before it merges. The review checklist is under Code review in CONTRIBUTING.md.