Skip to content

docs(governance): backup maintainer reviewed only the release PR - #155

Merged
jamesconwaydev merged 2 commits into
mainfrom
docs/backup-foothillsdigital
Nov 15, 2026
Merged

jamesconwaydev merged 2 commits into
mainfrom
docs/backup-foothillsdigital

Conversation

@jamesconwaydev

Copy link
Copy Markdown
Owner

@foothillsdigital takes over from @j-dahl7 as backup maintainer. Thanks for stepping in.

What changes:

  • GOVERNANCE.md: you're the backup maintainer in the Roles table. Continuity is unchanged: you act for me if I can't be reached for 7 days.
  • CONTRIBUTING.md: you review every PR I open before it merges, not just the release PR. A security fix is the one exception: it ships first, and you review it afterwards.

This is also the first PR under the new rule, so it needs your approval before it merges. The review checklist is under Code review in CONTRIBUTING.md.

foothillsdigital takes over as backup maintainer from j-dahl7 and reviews
every maintainer PR before it merges, not just the release PR. Security
fixes still ship first and get reviewed afterwards.

Signed-off-by: James Conway <148910373+jamesconwaydev@users.noreply.github.com>

@foothillsdigital foothillsdigital left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read e0ff4f0 against the checklist under Code review:

  1. Worth having: yes. It moves the second read from release time to every maintainer PR, which is stricter than before.
  2. Tested: docs only, nothing to test.
  3. Safe: nothing here touches a host or the SELinux module.
  4. Small: three lines, all on the one change. The Releases paragraph is updated to match ("like any other maintainer PR"), so the two sections don't disagree.
  5. The words match: the Roles table, Code review and Releases now say the same thing.

The Protect main ruleset asks for one approval and doesn't require a code owner, so the rule as written works as is. One small thing for later: .github/CODEOWNERS is * @jamesconwaydev, so GitHub auto-requests the author on the maintainer's own PRs and the backup has to be added by hand each time. Adding @foothillsdigital there would route those requests automatically. GOVERNANCE.md's line that CODEOWNERS "routes every review to the maintainer" would then want updating too.

Approving.

…digital

Signed-off-by: James Conway <148910373+jamesconwaydev@users.noreply.github.com>
@jamesconwaydev
jamesconwaydev merged commit b17aa49 into main Nov 15, 2026
6 checks passed
@jamesconwaydev
jamesconwaydev deleted the docs/backup-foothillsdigital branch November 15, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants