Repository navigation
ecto - chore: sync defense-in-depth files from agentic - #416
Conversation
Refresh the Safe Chain bootstrap script to agentic 0506fb9 and append the missing Pull requests section from the AGENTS.md template at 18ca132. Co-authored-by: Jared Wray <me@jaredwray.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 406 406
Branches 94 94
=========================================
Hits 406 406 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9cac1aba1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| if [[ -f package.json ]] && grep -q '"packageManager"' package.json && command -v corepack >/dev/null; then | ||
| corepack enable | ||
| if ! command -v pnpm >/dev/null \ |
There was a problem hiding this comment.
Ignore blocking placeholders when probing for pnpm
When a Claude setup attempt exits before Corepack can provision pnpm, it leaves this script's blocking pnpm stub on the persisted CLAUDE_ENV_FILE path. On a later retry after Corepack becomes available, command -v pnpm resolves that stub, so both this fallback and the missing-pnpm check are skipped; Safe Chain consequently has no real pnpm to wrap and the final verification/install still fails. Detect and ignore the placeholder while preserving the required shim-first ordering.
AGENTS.md reference: AGENTS.md:L58-L59
Useful? React with 👍 / 👎.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Chore — sync defense-in-depth copies from jaredwray/agentic.
Summary
Refresh the stale Safe Chain bootstrap script and append the missing Pull requests section from the agentic
AGENTS.mdtemplate.DEFENSE_IN_DEPTH.mdis unchanged; its catalog is behind upstream and belongs todefense-in-depth-nodejs.Changes
scripts/setup-cloud-environment.shreplaced with upstream at0506fb922922f594e359d9cc357b76fa10ebbb9d(agenticmainb0bd68459cd2cbf359cb73fad872fef216e52965)AGENTS.mdPull requests section appended from upstream at18ca132c078558ad9a5fbbaf10d958537fb3e954Verification
bash -n scripts/setup-cloud-environment.shpnpm testpasses — 239 tests, 100% coverage