Added support for tracking FK ID updates.#202
Closed
barqshasbite wants to merge 2 commits intojazzband:masterfrom
Closed
Added support for tracking FK ID updates.#202barqshasbite wants to merge 2 commits intojazzband:masterfrom
barqshasbite wants to merge 2 commits intojazzband:masterfrom
Conversation
In Django, you can update the raw ID of a ForeignKey relation using the '*_id' field without assigning it a new model. This needs to be logged by the audit framework. Currently it does not detect these changes.
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
=========================================
- Coverage 83.43% 83.13% -0.3%
=========================================
Files 19 19
Lines 513 516 +3
=========================================
+ Hits 428 429 +1
- Misses 85 87 +2
Continue to review full report at Codecov.
|
Member
|
@hramezani do you think this and #280 are related? |
Contributor
Author
|
This change is no longer valid with the latest code base. A new pull request has been created to address the issue in latest master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Django, you can update the raw ID of a ForeignKey relation
using the '*_id' field without assigning it a new model. This
needs to be logged by the audit framework. Currently it does
not detect these changes.