Skip to content

Added support for tracking FK ID updates.#202

Closed
barqshasbite wants to merge 2 commits intojazzband:masterfrom
barqshasbite:track_fk_ids
Closed

Added support for tracking FK ID updates.#202
barqshasbite wants to merge 2 commits intojazzband:masterfrom
barqshasbite:track_fk_ids

Conversation

@barqshasbite
Copy link
Contributor

In Django, you can update the raw ID of a ForeignKey relation
using the '*_id' field without assigning it a new model. This
needs to be logged by the audit framework. Currently it does
not detect these changes.

In Django, you can update the raw ID of a ForeignKey relation
using the '*_id' field without assigning it a new model. This
needs to be logged by the audit framework. Currently it does
not detect these changes.
@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #202 into master will decrease coverage by 0.29%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #202     +/-   ##
=========================================
- Coverage   83.43%   83.13%   -0.3%     
=========================================
  Files          19       19             
  Lines         513      516      +3     
=========================================
+ Hits          428      429      +1     
- Misses         85       87      +2
Impacted Files Coverage Δ
src/auditlog/diff.py 84.5% <50%> (-2.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22978e...4fb7654. Read the comment docs.

@aqeelat
Copy link
Member

aqeelat commented Dec 17, 2022

@hramezani do you think this and #280 are related?

@barqshasbite
Copy link
Contributor Author

This change is no longer valid with the latest code base. A new pull request has been created to address the issue in latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants