Add invitee field to AbstractBaseInvitation model#268
Open
Flimm wants to merge 1 commit intojazzband:masterfrom
Open
Add invitee field to AbstractBaseInvitation model#268Flimm wants to merge 1 commit intojazzband:masterfrom
Flimm wants to merge 1 commit intojazzband:masterfrom
Conversation
This library has been designed to keep Invitation instances in the database, even after the invitation has been accepted and the user account has been created. The only reason to keep these invitations around is to have a track record of invitations. It seems likely in that case that the inviter would want to be able to interact with the new user account, depending on the application. They may want to visit their profile page or something. Before this commit, this was impossible to do, as there was nothing linking the invitation instance to a user instance. At first glance, it might seem that an email address would link both models, but that is not the case. A user is not obligated to sign up with the same email address that was used to invite them. Even if they do use the same email address, they may change their email address in their user account later on. So an email address could not be relied on to link these two models. This commit modifies the modify to add a new field: "invitee". It sets this field after signup. This requires that allauth be installed. Fixes jazzband#252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #252
I would like some feedback on this pull request before merging it with to
master. In particular, I'm interested in someone testing this code in a project integrating django-invitations.