feat(macros): add Type Text step type to keyboard macros#1399
Open
mikeshoss wants to merge 5 commits intojetkvm:devfrom
Open
feat(macros): add Type Text step type to keyboard macros#1399mikeshoss wants to merge 5 commits intojetkvm:devfrom
mikeshoss wants to merge 5 commits intojetkvm:devfrom
Conversation
|
|
… duplicate logic Both PasteModal.onConfirmPaste and useKeyboard.expandTextSteps had identical character-to-keystroke conversion loops. Extract the shared logic into a standalone textToMacroSteps() function that both now call, eliminating the duplication flagged in review. https://claude.ai/code/session_011WGGjmQiwkNQ7Rru8ovjTy
…ntent The hasContent check accepts step.text but the error message only mentioned keys and modifiers, which was misleading for Type Text steps. https://claude.ai/code/session_011WGGjmQiwkNQ7Rru8ovjTy
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 59324b5. Configure here.
Move watch-pr.sh exclusion to .git/info/exclude where personal developer scripts belong. https://claude.ai/code/session_011WGGjmQiwkNQ7Rru8ovjTy
Author
|
I have afree to the CLA for jetkvm/kvm mutiple times and it still shows that its not signed yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Problem
The macro editor only allows picking individual keys from a dropdown one at a time, making it impossible to type text strings like usernames, URLs, or commands within a macro.
Solution
Each macro step now has a Step Type toggle (Keys / Type Text). Users can mix both in a single macro:
Files Changed
Test plan
Note
Medium Risk
Medium risk because it changes macro step schema and execution flow (text expansion + keyboard-layout-dependent behavior), which could affect existing macro playback if edge cases slip through.
Overview
Adds a new Type Text option for macro steps, allowing macros to include freeform text alongside traditional key/modifier steps.
Macro execution now accepts an optional keyboard layout and expands
step.textinto per-character keystroke steps via sharedtextToMacroStepslogic (also reused byPasteModal). The macro editor UI is updated with a step-type toggle, textarea input, unsupported-character warnings, and validation now treats text as valid step content; localization strings are updated accordingly (including updating existing validation copy across languages).Reviewed by Cursor Bugbot for commit b6eb48e. Bugbot is set up for automated code reviews on this repo. Configure here.