Conversation
23 tasks
Collaborator
|
고생하셨습니다!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Part (해당되는 것만 체크)
#️⃣ 연관된 이슈
closes #34
🔎 작업 내용
1. 주요 변경 사항 요약
POST /v1/blocks/{blockId}/move추가MoveBlockRequest추가BlockService,BlockServiceImpl에 블록 이동/순서 변경 로직 추가sortKey재계산,version충돌 검증 반영2. 상세 내용 (선택)
parentId,afterBlockId,beforeBlockId,version으로 고정했습니다.version불일치 시409 Conflict를 반환합니다.parentId가 있으면 같은 문서 소속 활성 블록인지 검증합니다.400 Bad Request로 처리합니다.afterBlockId,beforeBlockId는 대상 부모 아래 활성 형제 집합 기준으로 검증합니다.OrderedSortKeyGenerator를 재사용했고, gap 부족 시SORT_KEY_REBALANCE_REQUIRED로 변환했습니다.요청 예시:
{ "parentId": "new-parent-block-id", "afterBlockId": "blk-a", "beforeBlockId": null, "version": 0 }3. 프롬프트 경로
4. 참조 문서 경로 (ADR, discussions, roadMap ...)
💬 집중 리뷰 요청
BlockServiceImpl.move(...)의 검증 로직과sortKey계산 방식이 요구사항에 맞는지 확인부탁드립니다!🧪 테스트 방법
1. 로컬 실행 방법
2. 테스트 시나리오
✅ PR 체크리스트