Skip to content

ci: add contract impact check workflow#58

Merged
jho951 merged 1 commit intodevfrom
codex/contract-check-workflow
Mar 30, 2026
Merged

ci: add contract impact check workflow#58
jho951 merged 1 commit intodevfrom
codex/contract-check-workflow

Conversation

@jho951
Copy link
Copy Markdown
Owner

@jho951 jho951 commented Mar 30, 2026

Summary\n- add \n- run contract impact gate for service on pull_request\n\n## Contract\n- script source: https://github.com/jho951/contract/blob/main/scripts/contract-impact-check.sh\n

@jho951 jho951 self-assigned this Mar 30, 2026
@jho951 jho951 merged commit 52ed67c into dev Mar 30, 2026
1 check passed
@jho951 jho951 deleted the codex/contract-check-workflow branch March 30, 2026 05:51
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a32d54795f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

env:
SERVICE_NAME: block
run: |
curl -fsSL https://raw.githubusercontent.com/jho951/contract/main/scripts/contract-impact-check.sh -o /tmp/contract-impact-check.sh
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin external script to immutable revision

Downloading and executing contract-impact-check.sh directly from the upstream main branch makes this CI gate non-deterministic and creates a supply-chain risk: any future upstream change (or compromise) will immediately run in our pull_request workflow with this repository’s GITHUB_TOKEN permissions, potentially breaking all PRs or running unintended logic. Use an immutable commit URL (or vendor the script in-repo) so behavior is stable and auditable.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant