Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a32d54795f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| SERVICE_NAME: block | ||
| run: | | ||
| curl -fsSL https://raw.githubusercontent.com/jho951/contract/main/scripts/contract-impact-check.sh -o /tmp/contract-impact-check.sh |
There was a problem hiding this comment.
Pin external script to immutable revision
Downloading and executing contract-impact-check.sh directly from the upstream main branch makes this CI gate non-deterministic and creates a supply-chain risk: any future upstream change (or compromise) will immediately run in our pull_request workflow with this repository’s GITHUB_TOKEN permissions, potentially breaking all PRs or running unintended logic. Use an immutable commit URL (or vendor the script in-repo) so behavior is stable and auditable.
Useful? React with 👍 / 👎.
Summary\n- add \n- run contract impact gate for service on pull_request\n\n## Contract\n- script source: https://github.com/jho951/contract/blob/main/scripts/contract-impact-check.sh\n