Skip to content

chore: isolate docker runtime networks#59

Merged
jho951 merged 3 commits intodevfrom
chore-docker-network-separation
Mar 30, 2026
Merged

chore: isolate docker runtime networks#59
jho951 merged 3 commits intodevfrom
chore-docker-network-separation

Conversation

@jho951
Copy link
Copy Markdown
Owner

@jho951 jho951 commented Mar 30, 2026

Summary

  • Remove host port publishing from docker compose files
  • Attach app/mysql to a private bridge network
  • Connect app to the shared service backbone network with the documents-service alias

Docs

  • Prompt log: prompts/2026-03-27-docker-env-split-and-run-scripts.md
  • ADR: docs/decisions/019-isolate-docker-runtime-on-private-and-shared-networks.md
  • REQUIREMENTS: not updated, because this is an infrastructure/runtime policy change rather than a product requirement change

@jho951 jho951 self-assigned this Mar 30, 2026
@jho951 jho951 added the refactor Improve code structure and readability without changing functionality label Mar 30, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0da944e025

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +56 to +58
service-backbone-shared:
external: true
name: ${MSA_SHARED_NETWORK:-msa-shared}
name: ${SERVICE_SHARED_NETWORK:-service-backbone-shared}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Create shared network before declaring it external

Marking service-backbone-shared as external: true makes docker compose up fail on fresh environments unless that network already exists, but our startup path (scripts/run-docker.sh up/all) only runs docker compose ... up -d and never creates it. In practice, a first-time bash scripts/run-docker.sh dev up now aborts with the missing-external-network error, so local runtime is no longer self-starting. Please either provision the network in the script or avoid requiring an external network for the default/dev compose path.

Useful? React with 👍 / 👎.

@jho951 jho951 merged commit ad6f262 into dev Mar 30, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Block-server Mar 30, 2026
@jho951 jho951 deleted the chore-docker-network-separation branch March 30, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Improve code structure and readability without changing functionality

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant