Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0da944e025
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
docker/docker-compose.dev.yml
Outdated
| service-backbone-shared: | ||
| external: true | ||
| name: ${MSA_SHARED_NETWORK:-msa-shared} | ||
| name: ${SERVICE_SHARED_NETWORK:-service-backbone-shared} |
There was a problem hiding this comment.
Create shared network before declaring it external
Marking service-backbone-shared as external: true makes docker compose up fail on fresh environments unless that network already exists, but our startup path (scripts/run-docker.sh up/all) only runs docker compose ... up -d and never creates it. In practice, a first-time bash scripts/run-docker.sh dev up now aborts with the missing-external-network error, so local runtime is no longer self-starting. Please either provision the network in the script or avoid requiring an external network for the default/dev compose path.
Useful? React with 👍 / 👎.
Summary
documents-servicealiasDocs