Repository navigation
JITSU-227: Add Meta Ads Reverse ETL audiences and conversions - #1535
Merged
Merged
Conversation
There was a problem hiding this comment.
Reviewed the Meta Reverse ETL runtime, provisioning and delivery/recovery paths, console validation, and the existing review-thread state.
Finding:
- The shared Meta credential schema now allows ordinary Conversion API destinations to be saved without a pixel/dataset ID; those event deliveries fail only when an event is processed.
absorbb
force-pushed
the
feat/jitsu-227-meta-reverse-etl
branch
from
October 7, 2026 12:59
623bfcf to
8143b89
Compare
There was a problem hiding this comment.
Reviewed the Meta Reverse ETL runtime, provisioning/recovery flow, conversion and audience payload validation, console configuration guards, and the related runner integration.
No new actionable findings. The existing review threads are resolved and were not re-raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Meta/Facebook Reverse ETL for
JITSU-227using the reverse-etl-destination skill and existing runner persistence.facebook-conversionsID and existing valid event behavior.Safety and scope
Persist creation intent before POST and discover uncertain creation by a random marker, never blind recreation. Journal provider-ready payloads and recover lost audience receipts by the exact session. Unknown conversion submission requires manual reconciliation, not replay. API acceptance is not audience matching or attribution. Partial receipts never fabricate per-row success. Permanent errors stop the run; tokens and raw provider error samples are not logged.
Mirror requires an exclusively managed baseline. Core owns snapshots, membership, ownership and addition-before-removal ordering. Empty models remove tracked membership; normal runs refresh unchanged members after 30 days for Meta's 90-day external-ID retention. No native replacement/clear-and-fill, target picker, audience identifier-array fan-out, account sharing, lookalike creation or match-quality reporting. Hightouch and Segment document creation/add-remove mirroring; no competitor code was copied.
Full contract, API references, mappings, prerequisites and recovery limitations:
libs/destination-functions/src/functions/facebook/REVERSE_ETL.md.Verification
No live advertising writes, database changes, resets or deployments. Meta test-event codes are not a sandbox; a live smoke test needs explicit account/target approval.
Deployment
Manual as requested; no
deploy:consolelabel. Deploy console and retl-runner together. No infra/schema migration. The legacy event missing-pixel guard ships with the next rotor build; existing configured event connections remain unchanged.