Repository navigation
components 0.6.0 (unpublished): one entry; lib/portable removed - #206
Merged
Merged
Conversation
…n, for a host that asks the address itself" This reverts commit 8557b80. It reached main without review: a VS Code sync on a branch that tracked origin/main pushed it (2026-11-07). The owner then chose another design: the store address is picked from Google's suggestions inside Form.BusinessInfo itself, once the library has a single entry (plan: retire lib/portable). main goes back to cf906c7, version 0.5.4, so nothing is published with showLocation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ess with Google's suggestions; portable deprecated Owner, 2026-11-07 (plan: retire lib/portable, phase 2). - Form.BusinessInfo: while the form can be edited, the store address is AutoCompleteInput, as the driver's operating address is (no GPS button, no «use my location» row). The picked suggestion's description is reported as `location`, clearing it reports '', and its server errors are listed under it (FieldErrorText). The suggestions have no read-only state, so under readOnly (the console) or isDisabled (a locked store) the address stays the field it was, and those renders are unchanged. - The barrel serves ZOOM and useModalFocus, which only portable.js served, so a host can drop lib/portable. portable.js is deprecated and goes in 0.6.0; PROJECT.md says so and documents the address. - Story BusinessInfoReadOnly. Tests: the suggestions while editable, the field under readOnly and isDisabled, the address's error, and the barrel serving the two names. NOT RUN (owner's decision, 2026-11-07): this repository cannot install (the root lock fails with ERESOLVE, as every CI run since 2026-09-18), so no test or lint ran; the changed files parse. The pinned render «app path: Form.BusinessInfo (editable, server errors)» (legacyTrees.json) now differs on purpose, the address being the suggestions; it is recaptured when the suite can run again. The test setup is unchanged: the barrel already loads under it (A-3). The app verifies this version once installed (plan phases 3, 4 and 6). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner, 2026-11-07 (plan: retire lib/portable, phase 5). Breaking: hosts import the package itself. CustomerApp stopped importing lib/portable in its phase 3. - src/portable.js and its guard (__tests__/portableEntry.test.js) are gone. ButtonWrapper's test no longer compares the two entries. - PROJECT.md: "One entry (0.6.0)" replaces the portable section: web differences live in .web.js twins, native modules in the host's web stubs, and a host's jest mock must not spread the barrel while it loads (two of its libraries import it back). The other mentions of the portable entry go. NOT RUN: as for 0.5.5, this repository cannot install (root lock ERESOLVE), so no test or lint ran; the changed files parse. Merge after the app's phase 3 is merged; then the owner publishes 0.6.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner, 2026-11-07. Plan «retire
lib/portable», phase 5. Version 0.6.0, unpublished. Breaking: hosts import the package itself.Merge order:
lib/portable) is merged.This branch starts on #205. Draft until step 3.
What changes
src/portable.jsand its guard (__tests__/portableEntry.test.js) are removed.ButtonWrapper's test no longer compares the two entries.PROJECT.md: «One entry (0.6.0)» replaces the portable section..web.jstwins; native modules, in the host's web stubs.Not run
As for 0.5.5, this repository cannot install: the root lock fails
npm ciwithERESOLVE, so no test or lint ran, and CI will be red. The changed files parse.🤖 Generated with Claude Code