Skip to content

components 0.6.0: order-narration ^0.0.10 as the peer (and the pending 0.5.5/0.6.0 work) - #207

Merged
joelmsanto merged 8 commits into
mainfrom
notif/narration-peer-2026-11-08
Nov 8, 2026
Merged

joelmsanto merged 8 commits into
mainfrom
notif/narration-peer-2026-11-08

Conversation

@joelmsanto

Copy link
Copy Markdown
Contributor

What

  • order-narration peer ^0.0.10. The app names each Android channel through order-narration 0.0.10, which only adds NOTIFICATION_CHANNELS, NOTIFICATION_SCOPES and notificationChannelFor. With ^0.0.9, which on 0.0.x means exactly 0.0.9, npm ci refused CustomerApp#615 (ERESOLVE).
  • On the owner's decision, the PR also carries the local main work that GitHub main does not have yet:
    • components 0.5.5: Form.BusinessInfo asks for the store address with Google's suggestions, and the portable build is deprecated;
    • components 0.6.0: one entry point, and lib/portable is removed;
    • ListItemChip logs nothing, and a chip that calls nothing reads as text;
    • PROJECT.md names main as the trunk.

Lockfile

Following the existing convention, the peer bump touches only package.json (as 190ebbf / components 0.4.4 did), and the lock is regenerated at release.

Until 0.6.0 is published, the lock cannot be regenerated: react-native-phone-input declares react-native-components >=0.1.71 as a peer. Every published RNC (≤ 0.5.4) still asks for order-narration ^0.0.9. No --legacy-peer-deps.

After merge

Publish 0.6.0 from main. Then CustomerApp#615 bumps to RNC 0.6.0.

🤖 Generated with Claude Code

Joely and others added 8 commits November 3, 2026 11:14
…as text

The chip left a console.log on every render. The non-call chip gets accessibilityRole="text", as StatusChip's does,
so the web does not announce a button that does nothing. Three tests pin both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n, for a host that asks the address itself"

This reverts commit 8557b80.

It reached main without review: a VS Code sync on a branch that tracked
origin/main pushed it (2026-11-07). The owner then chose another design: the
store address is picked from Google's suggestions inside Form.BusinessInfo
itself, once the library has a single entry (plan: retire lib/portable). main
goes back to cf906c7, version 0.5.4, so nothing is published with
showLocation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ess with Google's suggestions; portable deprecated

Owner, 2026-11-07 (plan: retire lib/portable, phase 2).

- Form.BusinessInfo: while the form can be edited, the store address is
  AutoCompleteInput, as the driver's operating address is (no GPS button, no
  «use my location» row). The picked suggestion's description is reported as
  `location`, clearing it reports '', and its server errors are listed under
  it (FieldErrorText). The suggestions have no read-only state, so under
  readOnly (the console) or isDisabled (a locked store) the address stays the
  field it was, and those renders are unchanged.
- The barrel serves ZOOM and useModalFocus, which only portable.js served, so
  a host can drop lib/portable. portable.js is deprecated and goes in 0.6.0;
  PROJECT.md says so and documents the address.
- Story BusinessInfoReadOnly. Tests: the suggestions while editable, the field
  under readOnly and isDisabled, the address's error, and the barrel serving
  the two names.

NOT RUN (owner's decision, 2026-11-07): this repository cannot install (the
root lock fails with ERESOLVE, as every CI run since 2026-09-18), so no test or
lint ran; the changed files parse. The pinned render «app path:
Form.BusinessInfo (editable, server errors)» (legacyTrees.json) now differs on
purpose, the address being the suggestions; it is recaptured when the suite
can run again. The test setup is unchanged: the barrel already loads under it
(A-3). The app verifies this version once installed (plan phases 3, 4 and 6).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner, 2026-11-07 (plan: retire lib/portable, phase 5). Breaking: hosts import
the package itself. CustomerApp stopped importing lib/portable in its phase 3.

- src/portable.js and its guard (__tests__/portableEntry.test.js) are gone.
  ButtonWrapper's test no longer compares the two entries.
- PROJECT.md: "One entry (0.6.0)" replaces the portable section: web
  differences live in .web.js twins, native modules in the host's web stubs,
  and a host's jest mock must not spread the barrel while it loads (two of its
  libraries import it back). The other mentions of the portable entry go.

NOT RUN: as for 0.5.5, this repository cannot install (root lock ERESOLVE), so
no test or lint ran; the changed files parse.

Merge after the app's phase 3 is merged; then the owner publishes 0.6.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…othing, and a chip that calls nothing reads as text (2026-11-03 session), consolidated locally
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…shed; cleanup plan 2026-11-07)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The app names each Android channel through order-narration 0.0.10
(NOTIFICATION_CHANNELS, notificationChannelFor); 0.0.10 only adds those
exports. With ^0.0.9 (exactly 0.0.9 on 0.0.x) npm refused the app's
install (CustomerApp#615, ERESOLVE).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joelmsanto
joelmsanto merged commit 8fc8ff1 into main Nov 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant