Repository navigation
components 0.7.1: Form.PhoneNumber read-only, StripeForm.AccountBank shows the host's errors - #210
Merged
Merged
Conversation
…ad-only - Form.PhoneNumber takes `readOnly` (the name the package's forms use): the field takes no typing and its flag opens no country list. The app's step-up sends its code to the phone the account already has, and showed that number in a field that looked editable while ignoring what was typed. - Without the prop the form is what it was. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…'s errors under their inputs
- StripeForm.AccountBank takes `errors` (`{ field, code, message }`, the
shape Form.BusinessInfo and Form.VehicleInfo take) and shows each under its
input with FieldErrorText, the input marked. The form still validates
nothing by itself; without the prop it is the form it was.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Form.PhoneNumbertakesreadOnly(defaultfalse). Read-only, the phone field is not editable and its flag opens no country list. Version 0.7.1, not published yet.Why
CustomerApp's step-up (the SMS code before a bank change or an email change) sends its code to the phone the account already has, and shows that number through this form. The field looked editable and ignored what was typed (owner, 2026-11-11). The sign-up and the profile, where the number is typed, do not pass the prop and render as before.
Checked
Form/__tests__/FormPhoneNumber.test.js: 2 of 2. ESLint does not load in this checkout (its config package is not installed).Order
Publish 0.7.1, then CustomerApp takes it and passes
readOnlyfromStepUpSection.🤖 Generated with Claude Code