Skip to content

harness on CustomerApp's React 19.2.3 / RN 0.85.0; components 0.7.3 peers = the app's versions - #212

Merged
joelmsanto merged 3 commits into
mainfrom
harness/host-versions-2026-11-14
Nov 15, 2026
Merged

joelmsanto merged 3 commits into
mainfrom
harness/host-versions-2026-11-14

Conversation

@joelmsanto

Copy link
Copy Markdown
Contributor

What

  • The root is the Storybook/jest host of packages/components. It now runs CustomerApp's React 19.2.3 / React Native 0.85.0.
  • Every package the root shares with the app is pinned at the app's locked version.
  • The 0.75.4 → 0.85.0 upgrade follows the official template (rn-diff-purge).
  • components 0.7.3 (unpublished): the peers are the app's versions. Before this, react, react-native and @react-navigation/elements were "*".
  • Tests change in form only (owner OK):
    • StatusChip expects Paper 5.12.13+'s success/warning containers.
    • RuleClauseList wraps its press in act.
    • Three suites install a silent XMLHttpRequest, because the real places fork now requests suggestions.
    • legacyTrees.json was recaptured with the repo's capture tool.

Why

  • The host stayed on react 18.3.1 / RN 0.75.4 since 2024-12-16, while the app moved on. So the library's suites ran against a host that no longer exists.
  • Since 2.4.12 (b167662), our places fork asks for react >= 19 and RN >= 0.85. So the lock created in 56d7bff (2026-09-19) never installed (ERESOLVE).

Checked

  • The install is strict: no --force, no --legacy-peer-deps.
  • @jmstechnologiesinc resolves from dxr-artifacts, and no GitHub Packages URL is left in the lock.
  • npm ls: the shared packages equal CustomerApp's lock.
  • Full jest: 66 of 66 suites, 1484 tests. The capture suite is skipped unless asked.
  • Not run:
    • build-storybook, because the web map is out of scope (see below);
    • the iOS and Android builds, because the native Mapbox setup is out of scope;
    • lint.

Not in this PR

  • The web map. MapboxGLWrapper/index.web.js imports root react-map-gl, which v8 no longer exports, so build-storybook fails.
  • The host projects' native Mapbox setup. It has been missing since 58a57b2.
  • Lint. .eslintrc.js extends @react-native-community, which is not installed on main.
  • CI. GitHub Actions has no access to dxr-artifacts (owner's decision), so this workflow still fails at install. It also uses Node 20, below the template's engines (>= 22.11.0). Moving CI to Cloud Build is not decided.

Order

🤖 Generated with Claude Code

Joely and others added 3 commits November 14, 2026 21:25
…ative 0.85.0 and packages

The root is the private Storybook/jest host of packages/components. It stayed
on react 18.3.1 / RN 0.75.4 from 5181f08 (2024-12-16), while the app moved to
19.2.3 / 0.85.0. So the library's suites ran against a host that no longer
exists. And once our places fork asked for react >= 19 (2.4.12), the lock
(56d7bff) could not install.

- package.json: every package shared with CustomerApp is pinned at the app's
  locked version. partner 0.2.56, @react-navigation/elements 2.9.26 and
  react-native-worklets 0.9.2 are added at the app's versions. It also gets the
  app's `overrides` block and engines >= 22.11.0.
- package-lock.json was regenerated with a strict install (no --force, no
  --legacy-peer-deps). @jmstechnologiesinc resolves from dxr-artifacts, as in
  the app.
- The official 0.75.4 -> 0.85.0 template (rn-diff-purge) for android/ and ios/
  (AppDelegate.swift, no Tests target), plus the Gemfile, tsconfig and the jest
  preset. Gemfile.lock is the app's.
- babel: react-native-worklets/plugin (Reanimated 4).
- jest uses the official react-native-worklets and react-native-permissions
  mocks, and transforms gesture-handler and worklets (they ship ESM).
- Tests change in form only:
  - StatusChip expects Paper 5.12.13+'s success/warning containers.
  - RuleClauseList wraps onPress in act.
  - Form, legacyRendering and the legacy capture install a silent
    XMLHttpRequest, because the real places fork now requests suggestions.
  - legacyTrees.json was recaptured with the repo's capture tool:
    PaymentFrequency from 556ccd4, BusinessInfo from 58bd16d.

Not here: the web map (the react-map-gl v8 root import) and the native Mapbox
setup. Also not lint: main's config extends @react-native-community, which is
not installed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- react 19.2.3, react-native 0.85.0, react-native-reanimated 4.4.1, paper
  5.12.14 and partner 0.2.56, exactly as the app pins them. phone-input ^1.3.18
  and @react-navigation/elements ^2.9.22, as the app declares them. Before this,
  react, react-native and elements were "*".
- devDependencies: partner 0.2.56 and prettier 2.8.8, the app's.
- package-lock.json: only its two version lines change (npm version), as in
  55ab238.

It follows #211's 0.7.2. This branch is rebased once #211 merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

# Conflicts:
#	packages/components/package-lock.json
#	packages/components/package.json
@joelmsanto

Copy link
Copy Markdown
Contributor Author

Clean proof after merging main (#211) into this branch, at 11fb8c2:

The suites (ratchet) check stays red at install, because GitHub Actions has no access to dxr-artifacts (owner's decision). That is why this proof was run by hand.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant