Repository navigation
harness on CustomerApp's React 19.2.3 / RN 0.85.0; components 0.7.3 peers = the app's versions - #212
Merged
Merged
Conversation
…ative 0.85.0 and packages The root is the private Storybook/jest host of packages/components. It stayed on react 18.3.1 / RN 0.75.4 from 5181f08 (2024-12-16), while the app moved to 19.2.3 / 0.85.0. So the library's suites ran against a host that no longer exists. And once our places fork asked for react >= 19 (2.4.12), the lock (56d7bff) could not install. - package.json: every package shared with CustomerApp is pinned at the app's locked version. partner 0.2.56, @react-navigation/elements 2.9.26 and react-native-worklets 0.9.2 are added at the app's versions. It also gets the app's `overrides` block and engines >= 22.11.0. - package-lock.json was regenerated with a strict install (no --force, no --legacy-peer-deps). @jmstechnologiesinc resolves from dxr-artifacts, as in the app. - The official 0.75.4 -> 0.85.0 template (rn-diff-purge) for android/ and ios/ (AppDelegate.swift, no Tests target), plus the Gemfile, tsconfig and the jest preset. Gemfile.lock is the app's. - babel: react-native-worklets/plugin (Reanimated 4). - jest uses the official react-native-worklets and react-native-permissions mocks, and transforms gesture-handler and worklets (they ship ESM). - Tests change in form only: - StatusChip expects Paper 5.12.13+'s success/warning containers. - RuleClauseList wraps onPress in act. - Form, legacyRendering and the legacy capture install a silent XMLHttpRequest, because the real places fork now requests suggestions. - legacyTrees.json was recaptured with the repo's capture tool: PaymentFrequency from 556ccd4, BusinessInfo from 58bd16d. Not here: the web map (the react-map-gl v8 root import) and the native Mapbox setup. Also not lint: main's config extends @react-native-community, which is not installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- react 19.2.3, react-native 0.85.0, react-native-reanimated 4.4.1, paper 5.12.14 and partner 0.2.56, exactly as the app pins them. phone-input ^1.3.18 and @react-navigation/elements ^2.9.22, as the app declares them. Before this, react, react-native and elements were "*". - devDependencies: partner 0.2.56 and prettier 2.8.8, the app's. - package-lock.json: only its two version lines change (npm version), as in 55ab238. It follows #211's 0.7.2. This branch is rebased once #211 merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # packages/components/package-lock.json # packages/components/package.json
Contributor
Author
|
Clean proof after merging main (#211) into this branch, at 11fb8c2:
The 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
packages/components. It now runs CustomerApp's React 19.2.3 / React Native 0.85.0.components0.7.3 (unpublished): the peers are the app's versions. Before this,react,react-nativeand@react-navigation/elementswere"*".act.legacyTrees.jsonwas recaptured with the repo's capture tool.Why
Checked
--force, no--legacy-peer-deps.@jmstechnologiesincresolves from dxr-artifacts, and no GitHub Packages URL is left in the lock.npm ls: the shared packages equal CustomerApp's lock.build-storybook, because the web map is out of scope (see below);Not in this PR
MapboxGLWrapper/index.web.jsimports rootreact-map-gl, which v8 no longer exports, sobuild-storybookfails..eslintrc.jsextends@react-native-community, which is not installed on main.engines(>= 22.11.0). Moving CI to Cloud Build is not decided.Order
🤖 Generated with Claude Code