fix: use relative import in intesisbox.py to prevent system package conflict#70
Open
kesawi wants to merge 1 commit into
Open
fix: use relative import in intesisbox.py to prevent system package conflict#70kesawi wants to merge 1 commit into
kesawi wants to merge 1 commit into
Conversation
…onflict intesisbox.py used an absolute import which breaks when pyintesishome is vendored inside another package, causing the system-installed package to be loaded instead of the vendored copy. Change to a relative import consistent with all other files in the package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intesisbox.py used an absolute import (
from pyintesishome.intesisbase import IntesisBase) which breaks when pyintesishome is vendored inside another package, causing the system-installed package to be loaded instead of the vendored copy. All other files in the package use relative imports — this change makes intesisbox.py consistent with the rest of the package.No impact on non-vendored use since relative imports within a package resolve correctly regardless of how the package is installed.