Repository navigation
fix(remote): stop Connect Phone QR code from being cropped - #289
Merged
Merged
Conversation
The dialog panel is a height-capped (80vh) flex column. The QR box kept the default flex-shrink, so on short windows it shrank below 200px and its overflow:hidden cropped the top and bottom of the code. Pin it to its size so the panel scrolls instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
🔍 Reviewed – no blocking issues found at Automated review pass (Claude Code). |
Owner
|
Thanks a lot @BigWebstas, that's a neat one-line fix for the cropped QR code. Merging! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On shorter windows the QR code in the Connect Phone dialog was cut off at the top and bottom.
Cause
The dialog panel is a flex column capped at
max-height: 80vh. The 200px QR box kept the defaultflex-shrink: 1, so when the panel ran out of room it shrank the box instead of scrolling. The box'soverflow: hiddenthen cropped the centred QR image.Fix
Set
flex-shrink: 0on the QR box so it keeps its size and the panel scrolls instead.Testing
npm run check, plus the unit and client test suites (via the pre-push hook)🤖 Generated with Claude Code