Repository navigation
task/if we have a pr open we should 4b0a71 - #304
Conversation
johannesjo
commented
Oct 10, 2026
johannesjo
commented
- feat(tasks): add persistent snooze modes to Later menu
- feat(finish): merge through the task's open PR
When a task has an open PR, Finish merges it on GitHub with a method picker; a local merge stays available. A merged PR turns the footer into Close task. Closed PRs, PRs on another branch, and PRs that fail to load fall back to a local merge. Fix CI and Address review show when relevant. PR logic is shared with PullRequestDialog via pr-actions.ts.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fbe173d57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| void mergeAndClose(); | ||
| if (pr.mode() === 'merged') { | ||
| props.onClose(); | ||
| props.onCloseTask(); |
There was a problem hiding this comment.
When a PR has just merged—or was already detected as merged—this callback opens the generic close dialog, whose confirm handler unconditionally calls armSpCompletion(..., { kind: 'closed' }) in CloseTaskDialog.tsx. Consequently, a linked Super Productivity task is completed with a “Closed in Parallel Code” note even though Finish merged its PR; the local merge and coordinator landing paths explicitly preserve kind: 'merged'. Pass the merged completion context through this close handoff so integrations record the actual outcome.
Useful? React with 👍 / 👎.
1 participant
