Repository navigation
Use CakePHP native trusted HTML values - #47
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 1090 1087 -3
===========================================
Files 120 119 -1
Lines 2942 2942
===========================================
Hits 2942 2942 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Form labels, help, choices, summaries, embeds, and action captions now accept CakePHP's
HtmlStringablecontract. Templates useHtmlString::render()to escape ordinary strings and preserve explicitly trusted content; examples and tests use thehtml()factory to create trusted markup.Updates the locked CakePHP 6.x build to include cakephp/cakephp#19731 and removes
FormCompose\Rendering\Html. Documentation describes the native API. Regression tests exercise application-definedHtmlStringablecontent through public form APIs and verify attributes and input values remain escaped.Validation:
composer validate --strictcomposer check: 820 tests, 3,303 assertions; analysis, lint, Rector, and format checks passcomposer test-coveragewith Xdebug: 100% source line coverage (2,517/2,517); greater-than-90% gate passesnpm ciandnpm run docs:build(rerun after documentation cleanup)git diff --check