Repository navigation
JEP-0018: mTLS Workload Identity as the Default Authentication Mechanism - #1336
Closed
kirkbrauer wants to merge 4 commits into
Closed
kirkbrauer wants to merge 4 commits into
kirkbrauer wants to merge 4 commits into
Conversation
Propose mutual TLS with SPIFFE X.509 identities as the default authentication mechanism, with a vendor-neutral integration contract, built-in EST enrollment in front of cert-manager, and Teleport and OpenZiti + SPIRE reference integrations. The draft was checked against the controller, router, operator and Python client on main. Where the code contradicted it, the proposal was corrected: EST is served on the controller's passthrough listener rather than the edge-terminated login service, X.509 identities get their own object resolution rule, router tokens are issued per side and bound to the SPIFFE ID, and certificates are verified in the authenticator rather than in the TLS handshake. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WEcV44SFfjz4wMaY86WJ4
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WEcV44SFfjz4wMaY86WJ4
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Enrollment certificates now carry the object's internal subject as their SPIFFE path and are treated as internal credentials, so they reuse the credential-kind rules from #1319 and #1320 and leave the authorizer unchanged. Certificates from other trust domains add one branch to object resolution. Credential sources target the Python client and exporter on main instead of waiting for the Rust core. Router token binding, the lease ceiling and the EST handlers are tied to the code they extend, and an implementation map lists where each change lands. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WEcV44SFfjz4wMaY86WJ4
Local clusters made with 'jmp admin create cluster' enroll against an operator-managed CA, so the getting-started commands stay the same and need no approver-policy, OIDC provider or insecure flag. A renewal grace period keeps an idle laptop or unplugged exporter working. Direct mode gains pairing: a one-time code, then mutual TLS between remembered certificates, replacing the insecure flag and the passphrase as the documented path. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WEcV44SFfjz4wMaY86WJ4
Member
Author
|
Closing in favour of #1337. The source branch was renamed to Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds JEP-0018 and lists it in the JEP index. Status is Draft; this PR is the discussion venue.
What it proposes
Mutual TLS with SPIFFE X.509 identities as the default way clients and exporters authenticate, in place of bearer tokens:
exec,spiffe,enrollment,file, and today'stoken).How it fits the code on
mainThe JEP was checked against the controller, router, operator and Python client, and the design was adjusted wherever the code contradicted it. The "Implementation map" section of the JEP lists where each change lands. The points most worth a reviewer's attention:
MetadataAttributesGetterderives the object name from any non-internal username, so a SPIFFE ID username would be forced onto a name likelab-example-com-jumpstarter-exporters-pi-07:8086behind edge TLS termination, so a client certificate cannot reach it:8082listener, which is passthrough and already sends non-gRPC requests to a gateway mux with no routes (DD-6)Dialmints one token and gives the same string to both sides. The exporter's only known certificate is the one on its long-livedListenstreamListenqueue entry (DD-8)UNAVAILABLE, which it retries as an outageUNAUTHENTICATED(DD-4)clientAuth: Requiredbearer.allowedPrincipalscsrattrs; the controller rejects any other namessl_channel_credentials;cryptographyis already a dependencymain, not deferred to the Rust coreleasePolicyexists withmaxTags, checked inCreateLeasemaxDurationis plumbed and checked the same way, inCreateLeaseandUpdateLeaseJumpstarterCR; controller and router parse it strictlyDesign Decisions (DD-1 to DD-9), Acceptance Criteria and Consequences were added, as the template requires for Standards Track.
Open points
identifiesrule they introduce. It should be implemented after them, and re-read if they change shape.approveSignerNamesfor external issuers) were checked against the cert-manager documentation.Dialreaches an exporter only through the controller replica holding itsListenstream. That is existing behavior, and token binding relies on it (Unresolved Question 7).Checks
make docsbuilds without warnings with the controller-version lookup stubbed locally; that lookup needsquay.io, which was unreachable from the environment this was prepared in. The stub is not part of this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_018WEcV44SFfjz4wMaY86WJ4