Repository navigation
fix(ui): keep group and kind on typed references - #3607
Open
codyhartsook wants to merge 1 commit into
Open
codyhartsook wants to merge 1 commit into
codyhartsook wants to merge 1 commit into
Conversation
codyhartsook
force-pushed
the
codyhartsook/ownedRefsUI
branch
2 times, most recently
from
November 10, 2026 18:50
60b6d70 to
ad0d241
Compare
codyhartsook
force-pushed
the
codyhartsook/ownedRefsUI
branch
from
November 10, 2026 19:07
ad0d241 to
be8d132
Compare
github-actions
Bot
added
bug
This comment has been minimized.
This comment has been minimized.
shashankram
previously approved these changes
Nov 10, 2026
codyhartsook
marked this pull request as ready for review
November 10, 2026 20:06
codyhartsook
force-pushed
the
codyhartsook/ownedRefsUI
branch
from
November 10, 2026 20:21
be8d132 to
daf10d2
Compare
timflannagan
previously approved these changes
Nov 10, 2026
Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>
codyhartsook
dismissed stale reviews from timflannagan and shashankram
via
November 10, 2026 22:12
11c092b
codyhartsook
force-pushed
the
codyhartsook/ownedRefsUI
branch
from
November 10, 2026 22:12
daf10d2 to
11c092b
Compare
shashankram
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #3604, which adds optional
groupandkindto model and MCP server references. This PR shows only the UI commit.The UI rebuilt references from the name alone, so saving a form dropped
groupandkind. That points a reference to another kind at the same-named default object, which #3604 exists to prevent.Editing a template now keeps
groupandkindon model and MCP server references. A server picked in the form still saves as a plainRemoteMCPServerreference.Change Type
Changelog
Validation
yarn typecheck,yarn testandyarn lint(0 errors).group: example.com, kind: Foosurvives a template edit.