Repository navigation
feat(skillsinit): replace git subprocesses with go-git - #3627
Open
ekam-walia wants to merge 1 commit into
Open
ekam-walia wants to merge 1 commit into
ekam-walia wants to merge 1 commit into
Conversation
ekam-walia
force-pushed
the
subprocess-git
branch
from
November 10, 2026 09:34
87fcebb to
18e7a9c
Compare
Author
|
/cc @timflannagan |
Author
|
Its just some linting error, fixing it ASAP |
Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com>
ekam-walia
force-pushed
the
subprocess-git
branch
from
November 10, 2026 15:15
708a3e7 to
a1b3490
Compare
Author
|
Done I have also fixed the lint Error, It should pass now, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os/execgit CLI calls (runGitIn) ingo/core/internal/skillsinit/git.gowith the pure-Gogithub.com/go-git/go-git/v5library.go/core/pkg/agentplugins/materialize_test.goto initialize and commit repositories usinggo-gitin-process.context.ContextthroughCloneGitCommitto ensure that network operations cleanly abort on context cancellation or timeouts, resolving [BUG] skills-init hangs forever when the git server goes silent mid-clone (git runs with no timeout) #3452 (clones hanging when git servers stall).Changes
go/core/internal/skillsinit/git.go:git init,remote add,fetch,checkout) forgo-gitAPI calls.repo.FetchContext(ctx, ...).go/core/pkg/agentplugins/materialize.go:ctxintoskillsinit.CloneGitCommit.go/core/pkg/agentplugins/materialize_test.go&git_test.go:go-git.TestCloneGitCommitHonorsContextTimeout).Testing
-race.gitbinary (PATH="" go test ./...).Fixes #3588