Repository navigation
Move the installer to pkg/kagent/install - #157
Merged
Merged
Conversation
kagent imports the installer, so it can't stay under cmd/kubectl-ate/internal. microvmassets moves with it. Fork-only packages live under pkg/kagent so upstream can't add a package at the same path. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
EItanya
force-pushed
the
installer-pkg
branch
from
November 8, 2026 16:07
30d528b to
9dc072d
Compare
EItanya
added a commit
that referenced
this pull request
Nov 8, 2026
…roviders (#159) * docs: list substrate-atelet among the published charts (#151) Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> (cherry picked from commit 19cc8d5) Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * charts: let egress use other credential providers (#152) * charts: let egress use other credential providers credentialProvider.enabled turns off the bundled Kubernetes Secret provider and its k8s.io route. credentialProvider.extraProviders points the egress gateway at providers deployed outside the chart, matching the ate-setup --credential-provider options. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * charts: move extra credential providers under atenetEgress credentialProvider configures the bundled provider. The extra providers configure the egress gateway. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> (cherry picked from commit 40c2eaa) Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * kubectl-ate: typed postgres and objectStore config for install (#153) * kubectl-ate: add typed objectStore config to install objectStore now takes a bucket and s3 or gcs settings, and the installer fills the atelet and substrate chart values from them. The substrate release's object store plugin now gets the S3 region, endpoint, path style and credentials too. Before, it had only the backend name. The bare objectStore: s3 form still works, and so do the raw chart values. The wizard asks for these settings instead of a values file. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * kubectl-ate: configure postgres and objectStore the same way postgres is now a struct with a type, like objectStore, and both still accept the type alone. The installer's RustFS is now objectStore type bundled, matching postgres. Configs that say rustfs still work. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * kubectl-ate: don't name the system namespace in install help TestNoNewHardcodedInstallLayoutInGo rejects ate-system literals. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> (cherry picked from commit dda7ca9) Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * kubectl-ate: per-operation installer options and exported steps (#154) * kubectl-ate: take install charts as an fs.FS A program that embeds the installer can pass charts it ships itself instead of writing them to a directory. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * kubectl-ate: split installer options per operation and export steps Upgrade and Uninstall take their own options, so Options holds only the cluster, charts and config. Step, Run and InstallSteps are exported so a caller can add steps to an install, such as setting up its own database before StepCheckDatabase. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> (cherry picked from commit d006b3b) Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * Move the installer to pkg/kagent/install (#157) kagent imports the installer, so it can't stay under cmd/kubectl-ate/internal. microvmassets moves with it. Fork-only packages live under pkg/kagent so upstream can't add a package at the same path. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> (cherry picked from commit 471cd0c) Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent will import the installer, so it moves out of
cmd/kubectl-ate/internal. Stacked on #154.This is a pure move.
cmd/kubectl-ate/internal/install(withtui) moves topkg/kagent/install, andcmd/kubectl-ate/internal/microvmassetsmoves topkg/kagent/microvmassets. Only import paths and one template comment change. Fork-only packages go underpkg/kagentso an upstream sync can't collide with them (see #156).I wrote this with Claude Code and reviewed the diff.