Repository navigation
Conversation
kagent installs its own charts with the helm binary. Add HelmInstall and HelmUninstall so it can install them with the same Helm client and rules as the substrate releases, from a chart it loads itself. The version mismatch error no longer names kubectl ate, since other programs show it. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Author
|
Closing. This put substrate's release rules on kagent's charts and returned step closures. kagent already uses the Helm SDK for its OCI chart, so it can install, upgrade and uninstall its own releases with it directly and wrap those calls in install.Step. Comment left by Claude on behalf of @EItanya |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent installs
kagentandkagent-crdsby running thehelmbinary. This addsHelmInstallandHelmUninstall, so kagent can use the installer's Helm client for them, with the same rules as the substrate releases:UpgradeStepswas called (install: export the upgrade and uninstall steps #163).kagent loads the chart itself, for example by pulling it from OCI with the Helm SDK.
The version mismatch error now says "upgrade it instead" rather than naming
kubectl ate upgrade, since kagent shows it too.I tested it on kind with a throwaway chart: install, reapply, refusing a newer chart version, and uninstall. There's no unit test, because the Helm client needs a cluster.
I wrote this with Claude Code and reviewed the diff.