Repository navigation
Various updates - #719
Merged
Merged
Various updates#719
Conversation
Signed-off-by: Nadine2016 <nadine.spies@solo.io>
Contributor
Docs preview
Both are uploaded Worker versions and serve no production traffic. |
artberger
approved these changes
Nov 10, 2026
| 1. Check that the destination is blocked before you grant access. | ||
| {{< tabs >}} | ||
| {{% tab name="Agent" %}} | ||
| The kagent runtime image does not include `curl`, so create a Session and ask the Agent to open a connection with its `bash` tool. |
Collaborator
There was a problem hiding this comment.
The kagent runtime image does not include
curl
do we expect them to try curl first or something? otherwise it read a little weird to me to lead with this extra info that is not super related to the step. Maybe put it at the end.
Suggested change
| The kagent runtime image does not include `curl`, so create a Session and ask the Agent to open a connection with its `bash` tool. | |
| Create a Session and ask the Agent to open a connection with its `bash` tool. (The kagent runtime image does not include `curl`.) |
|
|
||
| ## Origin format and limits {#origin-format} | ||
|
|
||
| An origin names exactly one scheme, host, and port. The scheme must be `http` or `https`. When the port is omitted, kagent uses `443` for `https` and `80` for `http`. The API server rejects an origin that contains a path, a query, a fragment, user information, or an IP address. |
Collaborator
There was a problem hiding this comment.
names exactly one scheme, host, and port
just wanted to check, does this mean it names all three of these, and only one each of all three? (like it can't leave one out and can't have multiple values for any)
Collaborator
There was a problem hiding this comment.
it says port can be omitted after, so I guess not. Maybe tweak the wording:
Suggested change
| An origin names exactly one scheme, host, and port. The scheme must be `http` or `https`. When the port is omitted, kagent uses `443` for `https` and `80` for `http`. The API server rejects an origin that contains a path, a query, a fragment, user information, or an IP address. | |
| An origin can have only one value for each scheme, host, and port. The scheme must be `http` or `https`. When the port is omitted, kagent uses `443` for `https` and `80` for `http`. The API server rejects an origin that contains a path, a query, a fragment, user information, or an IP address. |
| | `historyLength` | Keeps only the most recent messages of each task. Setting `0` returns none, and omitting the field returns every message. | | ||
| | `includeArtifacts` | Returns each task's artifacts. The default is `false`, so a list omits artifacts unless you ask for them. | | ||
|
|
||
| 3. Read the response. It holds the page of `tasks`, the `pageSize` that applied, and `totalSize`, which counts every task that matches the filters across all pages. The `nextPageToken` value is empty on the last page, so a caller pages until it comes back empty. To read the artifacts of a task that a list returned, set `includeArtifacts` or call `GetTask` with the task's `id`. |
Collaborator
There was a problem hiding this comment.
so a caller pages until it comes back empty
I am not sure if pages is the right word, like is it a verb that the caller is doing, or is a page something that the caller is getting, in which case maybe something like:
Suggested change
| 3. Read the response. It holds the page of `tasks`, the `pageSize` that applied, and `totalSize`, which counts every task that matches the filters across all pages. The `nextPageToken` value is empty on the last page, so a caller pages until it comes back empty. To read the artifacts of a task that a list returned, set `includeArtifacts` or call `GetTask` with the task's `id`. | |
| 3. Read the response. It holds the page of `tasks`, the `pageSize` that applied, and `totalSize`, which counts every task that matches the filters across all pages. The `nextPageToken` value is empty on the last page, so a caller gets pages until the response comes back empty. To read the artifacts of a task that a list returned, set `includeArtifacts` or call `GetTask` with the task's `id`. |
| * kagent makes up to ten attempts for each state that a task publishes, and the count carries across controller restarts. After the last attempt, kagent drops that delivery but keeps the callback registered, so the next state still reaches the receiver. | ||
| * kagent does not expose delivery status, so nothing reports whether a delivery failed. | ||
|
|
||
| Three Helm values tune delivery. Set them under `config.push`. |
Collaborator
There was a problem hiding this comment.
maybe don't specify in case this changes:
Suggested change
| Three Helm values tune delivery. Set them under `config.push`. | |
| To tune delivery, configure the following Helm values under `config.push`. |
Signed-off-by: Nadine2016 <nadine.spies@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.