Auto clear after timeout should be x-kde-passwordManagerHint=secret#13301
Open
morawskidotmy wants to merge 3 commits intokeepassxreboot:developfrom
Open
Auto clear after timeout should be x-kde-passwordManagerHint=secret#13301morawskidotmy wants to merge 3 commits intokeepassxreboot:developfrom
morawskidotmy wants to merge 3 commits intokeepassxreboot:developfrom
Conversation
morawskidotmy
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the clipboard auto-clear behavior in the Qt GUI layer to ensure the “clear clipboard after timeout” operation is also treated as secret data on KDE (preventing KDE Connect from propagating a clear event to connected devices).
Changes:
- Replaced direct
QClipboard::clear()calls withsetText("", false)so the clear operation goes through the secret-tagging path. - On Unix/Wayland, only invokes
wl-copy -cif the in-process clear attempt didn’t actually change the clipboard contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copying a password from keepass the password itself was properly marked as x-kde-passwordManagerHint=secret but the clear() signal wasnt which caused keepass to clear phones clipboard through kde connect. Changed it to be marked as secret as well to prevent that. I dont know if there is another way to use qclipboard clear function with mime metadata but that'd prolly be a better solution.
Screenshots
Testing strategy
Built and ran current development branch, which yielded the same effect as ver 2.7.10 which im using currently (clear() sent to my phone). Built and ran version with changed code and confirmed the correct result eg. password nor clear() get sent to the phone.
Type of change